[PATCH] 2.6 open(O_EXCL) sets silly mtime

[PATCH] 2.6 open(O_EXCL) sets silly mtime

[Olaf Kirch]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hi,

the attached patch (relative to 2.6.5) is required to make sure a file
created with O_EXCL gets the proper mtime.

Olaf
-- 
Olaf Kirch     |  The Hardware Gods hate me.
okir@suse.de   |
---------------+ 

[-- Attachment #2: nfs-o-excl-mtime --]
[-- Type: text/plain, Size: 450 bytes --]

--- linux-2.6.5/fs/nfs/nfs3proc.c.excl	2004-04-19 14:35:47.000000000 +0200
+++ linux-2.6.5/fs/nfs/nfs3proc.c	2004-04-19 16:55:50.000000000 +0200
@@ -375,6 +375,9 @@
 		};
 		dprintk("NFS call  setattr (post-create)\n");
 
+		if (!(sattr->ia_valid & ATTR_MTIME_SET))
+			sattr->ia_valid |= ATTR_MTIME;
+
 		/* Note: we could use a guarded setattr here, but I'm
 		 * not sure this buys us anything (and I'd have
 		 * to revamp the NFSv3 XDR code) */

Re: [PATCH] 2.6 open(O_EXCL) sets silly mtime

[Trond Myklebust]

On Tue, 2004-04-20 at 04:18, Olaf Kirch wrote:
> Hi,
> 
> the attached patch (relative to 2.6.5) is required to make sure a file
> created with O_EXCL gets the proper mtime.

Well spotted. Should we also do the same for atime? AFAICS the server is
allowed to trash that too.

Hmm... Looking at the NFSv4 code, we really need to fix the same issues
up there too.

Cheers,
  Trond


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: [PATCH] 2.6 open(O_EXCL) sets silly mtime

[Olaf Kirch]

On Tue, Apr 20, 2004 at 10:47:53AM -0400, Trond Myklebust wrote:
> > the attached patch (relative to 2.6.5) is required to make sure a file
> > created with O_EXCL gets the proper mtime.
> 
> Well spotted. Should we also do the same for atime? AFAICS the server is
> allowed to trash that too.

If the spec says so, we should make sure atime gets set as well, yes.
I only fixed the mntime case because that's what the Linux nfsd clobbers.

Olaf
-- 
Olaf Kirch     |  The Hardware Gods hate me.
okir@suse.de   |
---------------+ 


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs