From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] - Replaces yield() with
Date: Sun, 25 Apr 2004 22:46:07 +0000 [thread overview]
Message-ID: <20040425224607.GF1394@masina> (raw)
In-Reply-To: <407C9AEE.5020808@legolas.alternex.com.br>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Sun, Apr 25, 2004 at 07:13:53PM -0300, Gustavo Franco wrote:
> Domen Puncer wrote:
>
> >...
> >
> >
> >>| >| --- drivers/cdrom/cdu31a.c.orig 2004-04-13 22:43:55.000000000 -0300
> >>| >| +++ drivers/cdrom/cdu31a.c 2004-04-13 22:44:17.000000000 -0300
> >>| >| @@ -386,7 +386,7 @@ static inline void sony_sleep(void)
> >>| >| unsigned long flags;
> >>| >|
> >>| >|
> >>| >| if (cdu31a_irq <= 0) {
> >>| >| - yield();
> >>| >| + schedule_timeout(1);
> >>
> >>
> >
> >set_current_state() missing.
> >
> >
> Are you talking about something like:
> <http://www.iglu.org.il/lxr/ident?i=set_current_state>
> set_current_state(TASK_UNINTERRUPTIBLE);
> schedule_timeout(1);
>
> Is is really necessary?
Yes, comment above schedule_timeout:
* Make the current task sleep until @timeout jiffies have
* elapsed. The routine will return immediately unless
* the current task state has been set (see set_current_state()).
...the "immediately" part
>
> Thanks,
> Gustavo Franco -- <stratus@acm.org>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-04-25 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 1:59 [Kernel-janitors] [PATCH] - Replaces yield() with Gustavo Franco
2004-04-15 23:09 ` Randy.Dunlap
2004-04-16 2:13 ` Gustavo Franco
2004-04-16 2:27 ` Randy.Dunlap
2004-04-25 19:44 ` Domen Puncer
2004-04-25 22:13 ` Gustavo Franco
2004-04-25 22:46 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040425224607.GF1394@masina \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.