All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] Replaces yield() with
Date: Wed, 28 Apr 2004 21:03:56 +0000	[thread overview]
Message-ID: <20040428210356.GB5495@sputnik.stro.at> (raw)
In-Reply-To: <408AB344.6010000@acm.org>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

hello,

On Mon, 26 Apr 2004, Felipe W Damasio wrote:

> Gustavo Franco wrote:
> >--- drivers/cdrom/sonycd535.c.orig    2004-04-24 13:46:28.000000000 -0300
> >+++ drivers/cdrom/sonycd535.c 2004-04-24 13:47:38.000000000 -0300
> >@@ -342,7 +342,7 @@
> >sony_sleep(void)
> >{
> >       if (sony535_irq_used <= 0) {    /* poll */
> >-               yield();
> >+               schedule_timeout(1);
> 
> 	I don't think it's that cut-and-dry...shouldn't you use something 
> relevant to HZ on this? Please see the patch maximilian sent on sis900 
> net driver.

jeff garzik prefers schedule_timeout(1) in the case of the sis900,
"that's IMO closer to the intention.."

regards maks


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-04-28 21:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-24 18:34 [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout() Gustavo Franco
2004-04-24 19:28 ` Gustavo Franco
2004-04-24 19:35 ` Gustavo Franco
2004-04-25 18:38 ` [Kernel-janitors] [PATCH] Replaces yield() with Domen Puncer
2004-04-25 23:10 ` [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout() Gustavo Franco
2004-04-25 23:25 ` [Kernel-janitors] [PATCH] Replaces yield() with Randy.Dunlap
2004-04-26  0:47 ` [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout() Gustavo Franco
2004-04-26  1:29 ` [Kernel-janitors] [PATCH] Replaces yield() with Randy.Dunlap
2004-04-26 12:23 ` [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout() Felipe W Damasio
2004-04-28 21:03 ` maximilian attems [this message]
2004-04-28 21:07 ` [Kernel-janitors] [PATCH] Replaces yield() with Randy.Dunlap
2004-04-28 21:13 ` [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout() Felipe W Damasio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040428210356.GB5495@sputnik.stro.at \
    --to=janitor@sternwelten.at \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.