Re: [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout()

From: Felipe W Damasio <felipewd@terra.com.br>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] Replaces yield() with schedule_timeout()
Date: Mon, 26 Apr 2004 12:23:01 +0000	[thread overview]
Message-ID: <408CFF25.2060802@terra.com.br> (raw)
In-Reply-To: <408AB344.6010000@acm.org>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

	Hi,

Gustavo Franco wrote:
> I guess that it's ok, please apply.
> 
> Thanks,
> Gustavo Franco
> 
> 
> --- drivers/cdrom/sonycd535.c.orig    2004-04-24 13:46:28.000000000 -0300
> +++ drivers/cdrom/sonycd535.c 2004-04-24 13:47:38.000000000 -0300
> @@ -342,7 +342,7 @@
> sony_sleep(void)
> {
>        if (sony535_irq_used <= 0) {    /* poll */
> -               yield();
> +               schedule_timeout(1);

	I don't think it's that cut-and-dry...shouldn't you use something 
relevant to HZ on this? Please see the patch maximilian sent on sis900 
net driver.

	Also, don't forget to use TASK_INTERRUPTITBLE (with a set_current_state 
that uses a memory barrier) before using schedule_timeout, please.

	Cheers,

Felipe

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors