From: "Art Haas" <ahaas@airmail.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] Small cleanup to kernel/setup.c
Date: Tue, 04 May 2004 15:02:22 +0000 [thread overview]
Message-ID: <20040504150222.GC23807@artsapartment.org> (raw)
In-Reply-To: <20040504132104.GA23807@artsapartment.org>
On Tue, May 04, 2004 at 07:57:14AM -0700, Keith M Wesolowski wrote:
> On Tue, May 04, 2004 at 10:26:55AM -0400, Ben Collins wrote:
>
> > > I don't like the original because it keeps doing strcmp() tests more
> > > times than necessary. That was my motivation in doing changing this bit
> > > of code.
> >
> > Only happens once at boot. Can't be that much overhead. Could just add
> > else's in front of the later if's, and leave the formatting the same.
>
> Right, this is completely non-critical, and I also like the existing
> formatting. I see no good reason to change this.
>
So the formatting changes are out - what about the variable removal?
Art Haas
--
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.
-Thomas Jefferson to James Smith, 1822
next prev parent reply other threads:[~2004-05-04 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-04 13:21 [PATCH] Small cleanup to kernel/setup.c Art Haas
2004-05-04 14:04 ` Ben Collins
2004-05-04 14:21 ` Art Haas
2004-05-04 14:26 ` Ben Collins
2004-05-04 14:57 ` Keith M Wesolowski
2004-05-04 15:02 ` Art Haas [this message]
2004-05-04 15:39 ` Keith M Wesolowski
2004-05-04 16:11 ` Thomas Nemeth
2004-05-04 16:37 ` Keith M Wesolowski
2004-05-04 16:42 ` Art Haas
2004-05-04 18:09 ` Keith M Wesolowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040504150222.GC23807@artsapartment.org \
--to=ahaas@airmail.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.