From: Keith M Wesolowski <wesolows@foobazco.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] Small cleanup to kernel/setup.c
Date: Tue, 04 May 2004 16:37:35 +0000 [thread overview]
Message-ID: <20040504163735.GA4333@foobazco.org> (raw)
In-Reply-To: <20040504132104.GA23807@artsapartment.org>
On Tue, May 04, 2004 at 06:11:44PM +0200, Thomas Nemeth wrote:
> Why don't you just remove all strcmp's ?
> Something like
> if (strlen(&cputypval)=4)
> sparc_cpu_model=sun4;
It's not "sun4" but rather "sun4 " so this is wrong.
> else if (&cputypval[4]='c')
> sparc_cpu_model=sun4c;
> else if (&cputypval[4]='d')
> sparc_cpu_model=sun4d;
See also head.S.
Any patch that modifies this stuff needs to make a significant
improvement; for example, setting these values early in head.S and
getting rid of this altogether.
But really it is not worth spending time on.
--
Keith M Wesolowski
next prev parent reply other threads:[~2004-05-04 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-04 13:21 [PATCH] Small cleanup to kernel/setup.c Art Haas
2004-05-04 14:04 ` Ben Collins
2004-05-04 14:21 ` Art Haas
2004-05-04 14:26 ` Ben Collins
2004-05-04 14:57 ` Keith M Wesolowski
2004-05-04 15:02 ` Art Haas
2004-05-04 15:39 ` Keith M Wesolowski
2004-05-04 16:11 ` Thomas Nemeth
2004-05-04 16:37 ` Keith M Wesolowski [this message]
2004-05-04 16:42 ` Art Haas
2004-05-04 18:09 ` Keith M Wesolowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040504163735.GA4333@foobazco.org \
--to=wesolows@foobazco.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.