From: Andrew Morton <akpm@osdl.org>
To: Patrice Bouchand <PBouchand@cyberdeck.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ib700wdt watchdog driver for 2.6.6
Date: Tue, 11 May 2004 01:32:23 -0700 [thread overview]
Message-ID: <20040511013223.2c1eafe8.akpm@osdl.org> (raw)
In-Reply-To: <200405101757.58104.PBouchand@cyberdeck.com>
Patrice Bouchand <PBouchand@cyberdeck.com> wrote:
>
> --- ./ib700wdt.c.orig 2004-05-10 08:57:54.000000000 +0200
> +++ ./ib700wdt.c 2004-05-10 08:44:50.000000000 +0200
> @@ -135,7 +135,7 @@
> ibwdt_ping(void)
> {
> /* Write a watchdog value */
> - outb_p(wd_times[wd_margin], WDT_START);
> + outb_p(wd_margin, WDT_START);
> }
The patch certainly looks sensible, but what about ibwdt_close() and
ibwdt_notify_sys()? They're doing
outb_p(wd_times[wd_margin], WDT_STOP);
which also seems peculiar.
next prev parent reply other threads:[~2004-05-11 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-10 15:57 [PATCH] ib700wdt watchdog driver for 2.6.6 Patrice Bouchand
2004-05-11 8:32 ` Andrew Morton [this message]
2004-05-11 9:01 ` Patrice Bouchand
2004-05-11 9:11 ` Andrew Morton
2004-05-11 9:21 ` Patrice Bouchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511013223.2c1eafe8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=PBouchand@cyberdeck.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.