All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice Bouchand <PBouchand@cyberdeck.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ib700wdt watchdog driver for 2.6.6
Date: Tue, 11 May 2004 11:01:37 +0200	[thread overview]
Message-ID: <200405111101.37376.PBouchand@cyberdeck.com> (raw)
In-Reply-To: <20040511013223.2c1eafe8.akpm@osdl.org>

> The patch certainly looks sensible, but what about ibwdt_close() and
> ibwdt_notify_sys()?  They're doing
>
> 		outb_p(wd_times[wd_margin], WDT_STOP);
>
> which also seems peculiar.


	The value written in the WDT_STOP register is not important. As soon as something is written , the watchdog timer stops.
 But you are right, things will be cleaner if we use the following patch.

	Thanks for the comments.

	Best regards

			Patrice Bouchand

-----------------------------------------------------------------------------------------------------------------------------------
--- ./ib700wdt.c.orig   2004-05-10 08:57:54.000000000 +0200
+++ ib700wdt.c  2004-05-11 10:50:54.000000000 +0200
@@ -135,7 +135,7 @@
 ibwdt_ping(void)
 {
        /* Write a watchdog value */
-       outb_p(wd_times[wd_margin], WDT_START);
+       outb_p(wd_margin, WDT_START);
 }

 static ssize_t
@@ -234,7 +234,7 @@
 {
        spin_lock(&ibwdt_lock);
        if (expect_close == 42)
-               outb_p(wd_times[wd_margin], WDT_STOP);
+               outb_p(wd_margin, WDT_STOP);
        else
                printk(KERN_CRIT PFX "WDT device closed unexpectedly.  WDT will not stop!\n");

@@ -254,7 +254,7 @@
 {
        if (code == SYS_DOWN || code == SYS_HALT) {
                /* Turn the WDT off */
-               outb_p(wd_times[wd_margin], WDT_STOP);
+               outb_p(wd_margin, WDT_STOP);
        }
        return NOTIFY_DONE;
 }



  reply	other threads:[~2004-05-11  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-10 15:57 [PATCH] ib700wdt watchdog driver for 2.6.6 Patrice Bouchand
2004-05-11  8:32 ` Andrew Morton
2004-05-11  9:01   ` Patrice Bouchand [this message]
2004-05-11  9:11     ` Andrew Morton
2004-05-11  9:21       ` Patrice Bouchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405111101.37376.PBouchand@cyberdeck.com \
    --to=pbouchand@cyberdeck.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.