powernow-k8-buggy-bios-override-for-266.patch

powernow-k8-buggy-bios-override-for-266.patch

[Dominik Brodowski]

Tony,

Can you post such patches on the cpufreq mailing list
(cpufreq@www.linux.org.uk) too, in future, please?

> This patch should be safe to apply, even if Pavel's ACPI table check is
> added to the driver.

Which check? I thought the powernow-k8 driver is quite up to date, Pavel?

 
-	if (query_current_values_with_pending_wait(data)) {
-		kfree(powernow_table);
-		return -EIO;
-	}
-

Why do you remove this check?


	Dominik

Re: powernow-k8-buggy-bios-override-for-266.patch

[Tony Lindgren]

* Dominik Brodowski <linux@dominikbrodowski.de> [040513 07:51]:
> Tony,
> 
> Can you post such patches on the cpufreq mailing list
> (cpufreq@www.linux.org.uk) too, in future, please?

Oops, sorry, will do.

> > This patch should be safe to apply, even if Pavel's ACPI table check is
> > added to the driver.
> 
> Which check? I thought the powernow-k8 driver is quite up to date, Pavel?

Hmmm, maybe it's integrated already? Have to check. But the driver by
default does not work for me.

> -	if (query_current_values_with_pending_wait(data)) {
> -		kfree(powernow_table);
> -		return -EIO;
> -	}
> -
> 
> Why do you remove this check?

Just moved it a bit earlier in the code as the values are needed earlier :)

Regards,

Tony

Re: powernow-k8-buggy-bios-override-for-266.patch

[Tony Lindgren]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

* Dominik Brodowski <linux@dominikbrodowski.de> [040513 07:51]:
> 
> > This patch should be safe to apply, even if Pavel's ACPI table check is
> > added to the driver.
> 
> Which check? I thought the powernow-k8 driver is quite up to date, Pavel?

OK, after some further investigating here's what happens. The ACPI table
parsing is there, and works. I was just updating my patch to 2.6.6, and 
did not pay much attention to what else had changed.

However, since my computer locks up as of 2.6.6 if ACPI processor is
compiled in, I've had it compiled as a module. Loading it after the init is
done does not lock up the system...

So I had CONFIG_ACPI_PROCESSOR=m, and that made the powernow-k8 ACPI
detection to fail. It now works good with the following little patch. Now
I also have the 1600MHz in addition to 800MHz and 1800MHz :)

I can keep my earlier patch around on my website in case somebody needs it.
It could also be included as secondary fallback if both ACPI and BIOS fail.

What happens with the ACPI speed tables with CPU upgrade BTW? Are they
hardcoded, or generated by the BIOS?

Regards,

Tony







[-- Attachment #2: patch-2.6.6-powernow-acpi-module --]
[-- Type: text/plain, Size: 1391 bytes --]

diff -Nru a/arch/i386/kernel/cpu/cpufreq/powernow-k8.c b/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
--- a/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	Thu May 13 09:58:24 2004
+++ b/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	Thu May 13 09:58:24 2004
@@ -32,7 +32,7 @@
 #include <asm/io.h>
 #include <asm/delay.h>
 
-#ifdef CONFIG_ACPI_PROCESSOR
+#if defined(CONFIG_ACPI_PROCESSOR) || defined(CONFIG_ACPI_PROCESSOR_MODULE)
 #include <linux/acpi.h>
 #include <acpi/processor.h>
 #endif
@@ -666,7 +696,7 @@
 	return -ENODEV;
 }
 
-#ifdef CONFIG_ACPI_PROCESSOR
+#if defined(CONFIG_ACPI_PROCESSOR) || defined(CONFIG_ACPI_PROCESSOR_MODULE)
 static void powernow_k8_acpi_pst_values(struct powernow_k8_data *data, unsigned int index)
 {
 	if (!data->acpi_data.state_count)
diff -Nru a/arch/i386/kernel/cpu/cpufreq/powernow-k8.h b/arch/i386/kernel/cpu/cpufreq/powernow-k8.h
--- a/arch/i386/kernel/cpu/cpufreq/powernow-k8.h	Thu May 13 09:58:24 2004
+++ b/arch/i386/kernel/cpu/cpufreq/powernow-k8.h	Thu May 13 09:58:24 2004
@@ -29,7 +29,7 @@
 	 * frequency is in kHz */
 	struct cpufreq_frequency_table  *powernow_table;
 
-#ifdef CONFIG_ACPI_PROCESSOR
+#if defined(CONFIG_ACPI_PROCESSOR) || defined(CONFIG_ACPI_PROCESSOR_MODULE)
 	/* the acpi table needs to be kept. it's only available if ACPI was
 	 * used to determine valid frequency/vid/fid states */
 	struct acpi_processor_performance acpi_data;

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq