2.6.6-mm1: nameif causes oops

2.6.6-mm1: nameif causes oops

[Jurriaan]

In my untainted 2.6.6-mm1 kernel, I see an oops (the one with the turtle
graphics) when booting, caused by the usage of nameif (which renames
ethernet interfaces from 'eth0' to 'adsl' for example).

dmove+0xc0/02fd
show_stack
show_registers
die
do_page_rault
error_code
sysfs_rename
kobject_rename
class_device_rename
dev_change_name
dev_ioctl
inet_ioctl
sock_ioctl
sys_ioctl
syscall_call

This is a smp (hyperthreading, single cpu) Pentium/4 system running
Debian Unstable.
I hope this is enough information, if not, let me know please.

This didn't happen in 2.6.6-rc3-mm1, by the way, which is the latest
kernel I tested before this one.

Kind regards,
Jurriaan
-- 
"If you hoped to arouse my deep antipathy, you have succeeded," said
Carfilhiot. "Otherwise, the occasion has been time wasted."
	Jack Vance - Lyonesse
Debian (Unstable) GNU/Linux 2.6.6-rc3-mm1 2x6062 bogomips 0.08 0.03

Re: 2.6.6-mm1: nameif causes oops

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Thu, 13 May 2004 19:28:49 +0200, Jurriaan <thunder7@xs4all.nl>  said:
> In my untainted 2.6.6-mm1 kernel, I see an oops (the one with the turtle
> graphics) when booting, caused by the usage of nameif (which renames
> ethernet interfaces from 'eth0' to 'adsl' for example).

Already shot, there's a patch that goes on -mm1:

http://marc.theaimsgroup.com/?l=linux-kernel&m=108426973229787&w=2

This is already in -mm2 as sysfs-backing-store-sysfs_rename_dir-fix.patch
I believe...

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.6-mm1: nameif causes oops

[Chris Wright]

* Jurriaan (thunder7@xs4all.nl) wrote:
> In my untainted 2.6.6-mm1 kernel, I see an oops (the one with the turtle
> graphics) when booting, caused by the usage of nameif (which renames
> ethernet interfaces from 'eth0' to 'adsl' for example).

This has been reported a few other times and Maneesh Soni <maneesh@in.ibm.com>
posted a patch already.  I added it below.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net


ok it is sysfs related and because of the backing store patches from me.

And here is the fix. Hope this solves your problem. 


Thanks
Maneesh

o Fix sysfs_rename_dir(). The sysfs_lookup() does not hash
  negative dentries so just hash it before calling d_move

 fs/sysfs/dir.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN fs/sysfs/dir.c~sysfs-backing-store-sysfs_rename_dir-fix fs/sysfs/dir.c
--- linux-2.6.6-mm1/fs/sysfs/dir.c~sysfs-backing-store-sysfs_rename_dir-fix	2004-10-06 15:21:37.000000000 +0530
+++ linux-2.6.6-mm1-maneesh/fs/sysfs/dir.c	2004-10-06 15:22:03.000000000 +0530
@@ -314,6 +314,7 @@ void sysfs_rename_dir(struct kobject * k
 	new_dentry = sysfs_get_dentry(parent, new_name);
 	if (!IS_ERR(new_dentry)) {
 		if (!new_dentry->d_inode) {
+			d_add(new_dentry, NULL);
 			d_move(kobj->dentry, new_dentry);
 			kobject_set_name(kobj,new_name);
 		}