[Kernel-janitors] Re: kjt patch-set for 2.6.7-rc1

[Kernel-janitors] Re: kjt patch-set for 2.6.7-rc1

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On 24/05/04 12:00 +0200, maximilian attems wrote:
> hello!
> 
Hi.

...
> this patch is intended for further _testing_ of our work.
> i hope that it helps Acme releasing the official kj ones.
> i won't forward anything to maintainers or lkml.
> will try to release on weekly/10days base.
...

Great idea!

I have one suggestion, try egrep -n "^\+(.* $|        )", to see if
patches introduce trailing spaces or spaces instead of tabs.
This also bit me, so below are links to 2 updated patches.

> +remove-old-ifdefs-fasttimer
http://coderock.org/kernel/janitor/old_ifdefs-take3/arch-cris-arch-v10-kernel-fasttimer.c_take2
> +remove-old-ifdefs-mtdcore
http://coderock.org/kernel/janitor/old_ifdefs-take3/drivers-mtd-mtdcore.c_take2


> +yield-nicedelay-sb1000
> +yield-schedtmout-megaraid
> +yield-schedtmout-sonycd535

These are the other patches that contain spaces.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Re: kjt patch-set for 2.6.7-rc1

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Mon, 24 May 2004, Domen Puncer wrote:

 ..
> Great idea!
> 
> I have one suggestion, try egrep -n "^\+(.* $|        )", to see if
> patches introduce trailing spaces or spaces instead of tabs.
> This also bit me, so below are links to 2 updated patches.

thanks for your nice feedback and hints, 
for the next releases i'll check the patches.
 
> > +remove-old-ifdefs-fasttimer
> http://coderock.org/kernel/janitor/old_ifdefs-take3/arch-cris-arch-v10-kernel-fasttimer.c_take2
> > +remove-old-ifdefs-mtdcore
> http://coderock.org/kernel/janitor/old_ifdefs-take3/drivers-mtd-mtdcore.c_take2
> > +yield-nicedelay-sb1000
> > +yield-schedtmout-megaraid
> > +yield-schedtmout-sonycd535
> 
> These are the other patches that contain spaces.

yours weren't run with '-p' diff switch (-> SubmittingPatches ;)
for now i've handedited those, didn't see further spaces,
patch a bit smaller now and lot cleaner!!!

great
a++ maks


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors