[Kernel-janitors] [PATCH] - fix pci/probe.c possible NULL pointer.

[Kernel-janitors] [PATCH] - fix pci/probe.c possible NULL pointer.

[Luiz Fernando N. Capitulino]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]


 Hi,

 In drivers/pci/probe.c::pci_scan_bridge() the call for pci_alloc_child_bus()
can return NULL, but it is not handled by the function (detected by
Coverity's checker).

 The patch bellow fix that returning `max' if we got the NULL, but
I do not know if it is right. I guess it is, because in that case
the function will act in the same way as with `pass != 0'.

Signed-off by: Luiz Capitulino <lcapitulino@prefeitura.sp.gov.br>

 drivers/pci/probe.c |    2 ++
 1 files changed, 2 insertions(+)


diff -X dontdiff -Nparu a/drivers/pci/probe.c a~/drivers/pci/probe.c
--- a/drivers/pci/probe.c	2004-05-24 14:44:34.000000000 -0300
+++ a~/drivers/pci/probe.c	2004-05-26 19:51:50.000000000 -0300
@@ -366,6 +366,8 @@ int __devinit pci_scan_bridge(struct pci
 			return max;
 		busnr = (buses >> 8) & 0xFF;
 		child = pci_alloc_child_bus(bus, dev, busnr);
+		if (!child)
+			return max;
 		child->primary = buses & 0xFF;
 		child->subordinate = (buses >> 16) & 0xFF;
 		child->bridge_ctl = bctl;
-- 
Luiz Fernando N. Capitulino
<http://www.telecentros.sp.gov.br>

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors