Re: [3/4] [PATCH]Diskdump - yet another crash dump function

[Ingo Molnar <mingo@elte.hu>]

* Christoph Hellwig <hch@infradead.org> wrote:

> > +/******************************** Disk dump ***********************************/
> > +#if defined(CONFIG_DISKDUMP) || defined(CONFIG_DISKDUMP_MODULE)
> > +#undef  add_timer
> > +#define add_timer       diskdump_add_timer
> > +#undef  del_timer_sync
> > +#define del_timer_sync  diskdump_del_timer
> > +#undef  del_timer
> > +#define del_timer       diskdump_del_timer
> > +#undef  mod_timer
> > +#define mod_timer       diskdump_mod_timer
> > +
> > +#define tasklet_schedule        diskdump_tasklet_schedule
> > +#endif
> 
> Yikes.  No way in hell we'll place code like this in drivers.  This
> needs to be handled in common code.

yeah, this is arguably the biggest (and i think only) conceptual item
that needs to be solved before this can be integrated.

The goal of these defines is to provide a separate (and polling based)
timer mechanism that is completely separate from the normal kernel's
state.

it would also be easier to enable diskdump in a driver if this was
handled in add_timer()/del_timer()/mod_timer()/tasklet_schedule().

	Ingo