From: Ralf Baechle <ralf@linux-mips.org>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: Emmanuel Michon <em@realmagic.fr>, linux-mips@linux-mips.org
Subject: Re: down_trylock() implementation for MIPS 4KEc CPU implies 64bit arithmetics?
Date: Fri, 28 May 2004 11:57:54 +0200 [thread overview]
Message-ID: <20040528095754.GA12295@linux-mips.org> (raw)
In-Reply-To: <20040528093634.GP17309@rembrandt.csv.ica.uni-stuttgart.de>
On Fri, May 28, 2004 at 11:36:34AM +0200, Thiemo Seufer wrote:
> Ralf Baechle wrote:
> [snip]
> > +static __inline__ int atomic64_sub_if_positive(int i, atomic64_t * v)
> > +{
> > + unsigned long temp, result;
> > +
> > + __asm__ __volatile__(
> > + "1: lld %1, %2 # atomic64_sub_if_positive\n"
> > + " subu %0, %1, %3 \n"
>
> Shouldn't this be "dsubu"?
Yep, thanks for noticing. Fortunately this function is unused; it only
exists for symmetry to it's 32-bit equivalent. I also a few variables
that should be long in the atomic64 code were just int; I fixed that
also.
Ralf
prev parent reply other threads:[~2004-05-28 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-26 16:35 down_trylock() implementation for MIPS 4KEc CPU implies 64bit arithmetics? Emmanuel Michon
2004-05-26 16:59 ` down_trylock() implementation for MIPS 4KEc CPU implies 64bitarithmetics? Kevin D. Kissell
2004-05-26 16:59 ` Kevin D. Kissell
2004-05-26 17:03 ` Emmanuel Michon
2004-05-26 17:16 ` Maciej W. Rozycki
2004-05-26 17:27 ` Emmanuel Michon
2004-05-26 17:40 ` Maciej W. Rozycki
2004-05-26 20:33 ` down_trylock() implementation for MIPS 4KEc CPU implies 64bit arithmetics? Ralf Baechle
2004-05-27 14:31 ` Emmanuel Michon
2004-05-27 15:59 ` Ralf Baechle
2004-05-28 0:35 ` Ralf Baechle
2004-05-28 9:36 ` Thiemo Seufer
2004-05-28 9:57 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040528095754.GA12295@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=em@realmagic.fr \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.