[uml-devel] [PATCH] More hostfs breakage

[uml-devel] [PATCH] More hostfs breakage

[Matt Zimmerman]

[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]

Even after applying Henrik's patches, hostfs was still not working for me.
I tracked the problem down to this; I'm not exactly sure why it works this
way (why does it always try to open the file read/write first?), but this
got it working again for me so far.

If this is really the right way to go about this, then it needs to check for
other things as well (EROFS?), but it doesn't seem right...

-- 
 - mdz

[-- Attachment #1.2: hostfs-perms.diff --]
[-- Type: text/plain, Size: 371 bytes --]

--- kernel-source-2.4.25/arch/um/fs/hostfs/host_fs.c~	2004-06-04 17:56:52.000000000 -0700
+++ kernel-source-2.4.25/arch/um/fs/hostfs/host_fs.c	2004-06-04 17:59:04.000000000 -0700
@@ -146,7 +146,7 @@
 	    kfree(fh);
 	    return NULL;
 	}
-	if (err == -EPERM)
+	if (err == -EPERM || err == -EACCES)
 	    err = host_open_file(path, 1, 0, fh);
 	if(err)
 		goto out_free;

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [uml-devel] [PATCH] More hostfs breakage

[Henrik Nordstrom]

Hmm.. I thought I had the "always one read-write" issue addressed in my 
patch to only open read-write if the UML application asks for it.. need to 
investigate.

  88e48f4e9b8d763f2d13d7a7974a3663  12-hostfs.patch
  50e3b372d77793ed2a8422f75364422f  13-hostfs_access.patch

Note that there has been 2 revisions of the 12-hostfs.patch. The first 
version did not use correct mode when opening files..

Regards
Henrik

On Fri, 4 Jun 2004, Matt Zimmerman wrote:

> Even after applying Henrik's patches, hostfs was still not working for me.
> I tracked the problem down to this; I'm not exactly sure why it works this
> way (why does it always try to open the file read/write first?), but this
> got it working again for me so far.
> 
> If this is really the right way to go about this, then it needs to check for
> other things as well (EROFS?), but it doesn't seem right...
> 
> 



-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] More hostfs breakage

[Matt Zimmerman]

On Sun, Jun 06, 2004 at 05:31:12PM +0200, Henrik Nordstrom wrote:

> Hmm.. I thought I had the "always one read-write" issue addressed in my 
> patch to only open read-write if the UML application asks for it.. need to 
> investigate.
> 
>   88e48f4e9b8d763f2d13d7a7974a3663  12-hostfs.patch
>   50e3b372d77793ed2a8422f75364422f  13-hostfs_access.patch
> 
> Note that there has been 2 revisions of the 12-hostfs.patch. The first 
> version did not use correct mode when opening files..

88e48f4e9b8d763f2d13d7a7974a3663  mara-12-hostfs.diff
50e3b372d77793ed2a8422f75364422f  mara-13-hostfs_access.diff

-- 
 - mdz


-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel