[PATCH 2.6.7-rc3] nr_free_files ?

[PATCH 2.6.7-rc3] nr_free_files ?

[FabF]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

Andrew,

	Here's a patch removing nr_free_files.This one is unused in the whole
tree + file-nr was tri-int exposed in /proc.This patch gives file-nr
simple integer as file-max.Could you apply if this doesn't break
historical features ?

Regards,
FabF

[-- Attachment #2: filenr1.diff --]
[-- Type: text/x-patch, Size: 868 bytes --]

diff -Naur orig/include/linux/fs.h edited/include/linux/fs.h
--- orig/include/linux/fs.h	2004-06-08 00:04:43.000000000 +0200
+++ edited/include/linux/fs.h	2004-06-08 22:50:36.000000000 +0200
@@ -49,7 +49,6 @@
 /* And dynamically-tunable limits and defaults: */
 struct files_stat_struct {
 	int nr_files;		/* read only */
-	int nr_free_files;	/* read only */
 	int max_files;		/* tunable */
 };
 extern struct files_stat_struct files_stat;
diff -Naur orig/kernel/sysctl.c edited/kernel/sysctl.c
--- orig/kernel/sysctl.c	2004-06-08 00:04:44.000000000 +0200
+++ edited/kernel/sysctl.c	2004-06-08 22:53:09.000000000 +0200
@@ -822,8 +822,8 @@
 	{
 		.ctl_name	= FS_NRFILE,
 		.procname	= "file-nr",
-		.data		= &files_stat,
-		.maxlen		= 3*sizeof(int),
+		.data		= &files_stat.nr_files,
+		.maxlen		= sizeof(int),
 		.mode		= 0444,
 		.proc_handler	= &proc_dointvec,
 	},

Re: [PATCH 2.6.7-rc3] nr_free_files ?

[Andrew Morton]

FabF <fabian.frederick@skynet.be> wrote:
>
> Here's a patch removing nr_free_files.

It changes the format of /proc/sys/fs/file-nr.

Re: [PATCH 2.6.7-rc3] nr_free_files ?

[Chris Wedgwood]

On Tue, Jun 08, 2004 at 02:17:12PM -0700, Andrew Morton wrote:

> It changes the format of /proc/sys/fs/file-nr.

For 2.7.x is think that's fine but clearly for 2.6.x it's not.  Are we
starting to queue stuff for 2.7.x yet? :)


  --cw

Re: [PATCH 2.6.7-rc3] nr_free_files ?

[FabF]

On Wed, 2004-06-09 at 00:19, Chris Wedgwood wrote:
> On Tue, Jun 08, 2004 at 02:17:12PM -0700, Andrew Morton wrote:
> 
> > It changes the format of /proc/sys/fs/file-nr.
> 
> For 2.7.x is think that's fine but clearly for 2.6.x it's not.  Are we
> starting to queue stuff for 2.7.x yet? :)
Who _can_ do that ?

FabF
> 
> 
>   --cw
>