* [PATCH] Remove notify in speedstep_set_state [1/2]
2004-06-10 16:44 ` Dominik Brodowski
@ 2004-06-10 19:26 ` Bruno Ducrot
0 siblings, 0 replies; 6+ messages in thread
From: Bruno Ducrot @ 2004-06-10 19:26 UTC (permalink / raw)
To: Dave Jones; +Cc: cpufreq
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Remove 'notify' in speedstep_set_state for speedstep-lib
Signed-Of-By: Bruno Ducrot <ducrot@poupinou.org>
arch/i386/kernel/cpu/cpufreq/speedstep-lib.c | 10 ++++------
arch/i386/kernel/cpu/cpufreq/speedstep-lib.h | 2 +-
2 files changed, 5 insertions(+), 7 deletions(-)
- --- linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2004/06/10 18:28:39 1.1
+++ linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2004/06/10 18:30:43
@@ -321,9 +321,7 @@ EXPORT_SYMBOL_GPL(speedstep_detect_proce
unsigned int speedstep_get_freqs(unsigned int processor,
unsigned int *low_speed,
unsigned int *high_speed,
- - void (*set_state) (unsigned int state,
- - unsigned int notify)
- - )
+ void (*set_state) (unsigned int state))
{
unsigned int prev_speed;
unsigned int ret = 0;
@@ -340,7 +338,7 @@ unsigned int speedstep_get_freqs(unsigne
local_irq_save(flags);
/* switch to low state */
- - set_state(SPEEDSTEP_LOW, 0);
+ set_state(SPEEDSTEP_LOW);
*low_speed = speedstep_get_processor_frequency(processor);
if (!*low_speed) {
ret = -EIO;
@@ -348,7 +346,7 @@ unsigned int speedstep_get_freqs(unsigne
}
/* switch to high state */
- - set_state(SPEEDSTEP_HIGH, 0);
+ set_state(SPEEDSTEP_HIGH);
*high_speed = speedstep_get_processor_frequency(processor);
if (!*high_speed) {
ret = -EIO;
@@ -362,7 +360,7 @@ unsigned int speedstep_get_freqs(unsigne
/* switch to previous state, if necessary */
if (*high_speed != prev_speed)
- - set_state(SPEEDSTEP_LOW, 0);
+ set_state(SPEEDSTEP_LOW);
out:
local_irq_restore(flags);
- --- linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.h 2004/06/10 18:28:29 1.1
+++ linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.h 2004/06/10 18:47:50
@@ -44,4 +44,4 @@ extern unsigned int speedstep_get_proces
extern unsigned int speedstep_get_freqs(unsigned int processor,
unsigned int *low_speed,
unsigned int *high_speed,
- - void (*set_state) (unsigned int state, unsigned int notify));
+ void (*set_state) (unsigned int state));
- --
Bruno Ducrot
- -- Which is worse: ignorance or apathy?
- -- Don't know. Don't care.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAyLXwiZtNKH9GMYcRArLaAJ97vEFTzsoFXBIqFNXsOeOI4nyr1QCeJwod
ewJTE56F+yqKoyN5kx9SxWU=
=+VHa
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Remove notify in speedstep_set_state [1/2]
@ 2004-06-11 10:02 Bruno Ducrot
2004-06-11 12:18 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Bruno Ducrot @ 2004-06-11 10:02 UTC (permalink / raw)
To: Dave Jones; +Cc: cpufreq
Remove 'notify' in speedstep_set_state for speedstep-lib
Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
speedstep-lib.c | 10 ++++------
speedstep-lib.h | 2 +-
2 files changed, 5 insertions(+), 7 deletions(-)
--- linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2004/06/10 18:28:39 1.1
+++ linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2004/06/10 18:30:43
@@ -321,9 +321,7 @@ EXPORT_SYMBOL_GPL(speedstep_detect_proce
unsigned int speedstep_get_freqs(unsigned int processor,
unsigned int *low_speed,
unsigned int *high_speed,
- void (*set_state) (unsigned int state,
- unsigned int notify)
- )
+ void (*set_state) (unsigned int state))
{
unsigned int prev_speed;
unsigned int ret = 0;
@@ -340,7 +338,7 @@ unsigned int speedstep_get_freqs(unsigne
local_irq_save(flags);
/* switch to low state */
- set_state(SPEEDSTEP_LOW, 0);
+ set_state(SPEEDSTEP_LOW);
*low_speed = speedstep_get_processor_frequency(processor);
if (!*low_speed) {
ret = -EIO;
@@ -348,7 +346,7 @@ unsigned int speedstep_get_freqs(unsigne
}
/* switch to high state */
- set_state(SPEEDSTEP_HIGH, 0);
+ set_state(SPEEDSTEP_HIGH);
*high_speed = speedstep_get_processor_frequency(processor);
if (!*high_speed) {
ret = -EIO;
@@ -362,7 +360,7 @@ unsigned int speedstep_get_freqs(unsigne
/* switch to previous state, if necessary */
if (*high_speed != prev_speed)
- set_state(SPEEDSTEP_LOW, 0);
+ set_state(SPEEDSTEP_LOW);
out:
local_irq_restore(flags);
--- linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.h 2004/06/10 18:28:29 1.1
+++ linux-2.6.7-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-lib.h 2004/06/10 18:47:50
@@ -44,4 +44,4 @@ extern unsigned int speedstep_get_proces
extern unsigned int speedstep_get_freqs(unsigned int processor,
unsigned int *low_speed,
unsigned int *high_speed,
- void (*set_state) (unsigned int state, unsigned int notify));
+ void (*set_state) (unsigned int state));
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove notify in speedstep_set_state [1/2]
2004-06-11 10:02 [PATCH] Remove notify in speedstep_set_state [1/2] Bruno Ducrot
@ 2004-06-11 12:18 ` Dave Jones
2004-06-11 13:07 ` Bruno Ducrot
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2004-06-11 12:18 UTC (permalink / raw)
To: Bruno Ducrot; +Cc: cpufreq
On Fri, Jun 11, 2004 at 12:02:23PM +0200, Bruno Ducrot wrote:
> Remove 'notify' in speedstep_set_state for speedstep-lib
>
> Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
How about [3/2] Fix speedstep-ich 8-)
CC arch/i386/kernel/cpu/cpufreq/speedstep-ich.o
arch/i386/kernel/cpu/cpufreq/speedstep-ich.c: In function `speedstep_cpu_init':
arch/i386/kernel/cpu/cpufreq/speedstep-ich.c:291: warning: passing arg 4 of `speedstep_get_freqs' from incompatible pointer type
The p4-clockmod change also broke the compile here, but I'm fixing
that up (just looks like a missing #include)
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove notify in speedstep_set_state [1/2]
2004-06-11 12:18 ` Dave Jones
@ 2004-06-11 13:07 ` Bruno Ducrot
2004-06-11 13:11 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Bruno Ducrot @ 2004-06-11 13:07 UTC (permalink / raw)
To: Dave Jones; +Cc: cpufreq
On Fri, Jun 11, 2004 at 01:18:22PM +0100, Dave Jones wrote:
> On Fri, Jun 11, 2004 at 12:02:23PM +0200, Bruno Ducrot wrote:
> > Remove 'notify' in speedstep_set_state for speedstep-lib
> >
> > Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
>
> How about [3/2] Fix speedstep-ich 8-)
It's expected to be done by the latest
speedstep_patch.2.6.7-rc3_SMT.diff from Christian Hoelbling ;)
> The p4-clockmod change also broke the compile here, but I'm fixing
> that up (just looks like a missing #include)
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove notify in speedstep_set_state [1/2]
2004-06-11 13:07 ` Bruno Ducrot
@ 2004-06-11 13:11 ` Dave Jones
2004-06-11 13:24 ` Bruno Ducrot
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2004-06-11 13:11 UTC (permalink / raw)
To: Bruno Ducrot; +Cc: cpufreq
On Fri, Jun 11, 2004 at 03:07:45PM +0200, Bruno Ducrot wrote:
> On Fri, Jun 11, 2004 at 01:18:22PM +0100, Dave Jones wrote:
> > On Fri, Jun 11, 2004 at 12:02:23PM +0200, Bruno Ducrot wrote:
> > > Remove 'notify' in speedstep_set_state for speedstep-lib
> > >
> > > Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
> >
> > How about [3/2] Fix speedstep-ich 8-)
>
> It's expected to be done by the latest
> speedstep_patch.2.6.7-rc3_SMT.diff from Christian Hoelbling ;)
Ah, I lost track of what happened with that one.
Dominik mentioned you found some bug in it, but I'm not sure
I saw any follow-up patch. I'll go re-read the thread after
lunch and see if I can pick it up.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove notify in speedstep_set_state [1/2]
2004-06-11 13:11 ` Dave Jones
@ 2004-06-11 13:24 ` Bruno Ducrot
0 siblings, 0 replies; 6+ messages in thread
From: Bruno Ducrot @ 2004-06-11 13:24 UTC (permalink / raw)
To: Dave Jones; +Cc: cpufreq
On Fri, Jun 11, 2004 at 02:11:59PM +0100, Dave Jones wrote:
> On Fri, Jun 11, 2004 at 03:07:45PM +0200, Bruno Ducrot wrote:
> > On Fri, Jun 11, 2004 at 01:18:22PM +0100, Dave Jones wrote:
> > > On Fri, Jun 11, 2004 at 12:02:23PM +0200, Bruno Ducrot wrote:
> > > > Remove 'notify' in speedstep_set_state for speedstep-lib
> > > >
> > > > Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
> > >
> > > How about [3/2] Fix speedstep-ich 8-)
> >
> > It's expected to be done by the latest
> > speedstep_patch.2.6.7-rc3_SMT.diff from Christian Hoelbling ;)
>
> Ah, I lost track of what happened with that one.
> Dominik mentioned you found some bug in it, but I'm not sure
> I saw any follow-up patch. I'll go re-read the thread after
> lunch and see if I can pick it up.
You are right. It was not send as a follow-up patch, but was sent with
'subject [PATCH] 2.6.5 speedstep on P4Ms', though it's again 2.6.7-rc3 I
believe.
Cheers,
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-06-11 13:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-11 10:02 [PATCH] Remove notify in speedstep_set_state [1/2] Bruno Ducrot
2004-06-11 12:18 ` Dave Jones
2004-06-11 13:07 ` Bruno Ducrot
2004-06-11 13:11 ` Dave Jones
2004-06-11 13:24 ` Bruno Ducrot
-- strict thread matches above, loose matches on Subject: below --
2004-06-08 17:15 [PATCH] 2.6.5 speedstep on P4Ms Christian Hoelbling
2004-06-08 15:30 ` Bruno Ducrot
2004-06-08 23:53 ` Christian Hoelbling
2004-06-09 15:47 ` Dominik Brodowski
2004-06-10 0:46 ` Christian Hoelbling
2004-06-10 15:37 ` Bruno Ducrot
2004-06-10 16:44 ` Dominik Brodowski
2004-06-10 19:26 ` [PATCH] Remove notify in speedstep_set_state [1/2] Bruno Ducrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.