From: Andrew Morton <akpm@osdl.org>
To: Jun Sun <jsun@mvista.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, jsun@mvista.com
Subject: Re: [PATCH] make ps2 mouse work ...
Date: Tue, 15 Jun 2004 20:56:11 -0700 [thread overview]
Message-ID: <20040615205611.1e9cbfcc.akpm@osdl.org> (raw)
In-Reply-To: <20040615191023.G28403@mvista.com>
Jun Sun <jsun@mvista.com> wrote:
>
>
> I found this problem on a MIPS machine. The problem is
> likely to happen on other register-rich RISC arches too.
>
> cmdcnt needs to be volatile since it is modified by
> irq routine and read by normal process context.
volatile is not the preferred way to fix this up. This points at either a
locking error in the psmouse driver or a missing "memory" thingy in the
mips port somewhere.
Please describe the bug which led to this patch. Where was it getting stuck?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Jun Sun <jsun@mvista.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] make ps2 mouse work ...
Date: Tue, 15 Jun 2004 20:56:11 -0700 [thread overview]
Message-ID: <20040615205611.1e9cbfcc.akpm@osdl.org> (raw)
Message-ID: <20040616035611.WzIaBhyAy09SljcTWxBy2WdTZG4eQI1vKA0iW49I74M@z> (raw)
In-Reply-To: <20040615191023.G28403@mvista.com>
Jun Sun <jsun@mvista.com> wrote:
>
>
> I found this problem on a MIPS machine. The problem is
> likely to happen on other register-rich RISC arches too.
>
> cmdcnt needs to be volatile since it is modified by
> irq routine and read by normal process context.
volatile is not the preferred way to fix this up. This points at either a
locking error in the psmouse driver or a missing "memory" thingy in the
mips port somewhere.
Please describe the bug which led to this patch. Where was it getting stuck?
next prev parent reply other threads:[~2004-06-16 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 2:10 [PATCH] make ps2 mouse work Jun Sun
2004-06-16 3:56 ` Andrew Morton [this message]
2004-06-16 3:56 ` Andrew Morton
2004-06-16 12:11 ` Vojtech Pavlik
2004-06-16 17:04 ` Jun Sun
2004-06-16 17:58 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040615205611.1e9cbfcc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jsun@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.