From: Christoph Hellwig <hch@infradead.org>
To: Takao Indoh <indou.takao@soft.fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4]Diskdump Update
Date: Thu, 17 Jun 2004 14:39:06 +0100 [thread overview]
Message-ID: <20040617133906.GA32219@infradead.org> (raw)
In-Reply-To: <CCC4546DFE9D94indou.takao@soft.fujitsu.com>
On Thu, Jun 17, 2004 at 10:21:27PM +0900, Takao Indoh wrote:
> On Thu, 17 Jun 2004 13:49:57 +0100, Christoph Hellwig wrote:
>
> >my old comments for this are still valid, please add the actual dumping
> >methods directly to scsi_host_template instead of a pointer to another
> >method vector,
>
> I have already done in the latest patch.
Okay. Looks like I looked at an older patch, sorry.
>
> diff -Nur linux-2.6.6.org/drivers/scsi/aic7xxx/aic7xxx_osm.c linux-2.6.6/drivers/scsi/aic7xxx/aic7xxx_osm.c
> --- linux-2.6.6.org/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-06-04 21:22:20.000000000 +0900
> +++ linux-2.6.6/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-06-16 19:34:16.000000000 +0900
> @@ -774,6 +774,10 @@
> static int ahc_linux_bus_reset(Scsi_Cmnd *);
> static int ahc_linux_dev_reset(Scsi_Cmnd *);
> static int ahc_linux_abort(Scsi_Cmnd *);
> +#if defined(CONFIG_SCSI_DUMP) || defined(CONFIG_SCSI_DUMP_MODULE)
> +static int ahc_linux_sanity_check(struct scsi_device *);
> +static void ahc_linux_poll(struct scsi_device *);
> +#endif
I'd say implement these unconditionally, it's not _that_ much code..
> >please make it not a module of it's own but part of the
> >scsi code,
>
> Do you mean scsi_dump module should be merged with sd_mod.o or scsi_mod.o?
scsi_mod.o.
> I'll try sysfs attribute instead of this.
Okay, thanks. Or some other way to find by host/channel/target/lun using
scsi_device_lookup.
next prev parent reply other threads:[~2004-06-17 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 11:34 [PATCH 0/4]Diskdump Update Takao Indoh
2004-06-11 11:40 ` [PATCH 1/4]Diskdump Update Takao Indoh
2004-06-11 11:50 ` Arjan van de Ven
2004-06-11 13:40 ` Takao Indoh
2004-06-11 15:17 ` Martin J. Bligh
2004-06-14 1:38 ` Takao Indoh
2004-06-14 2:08 ` Martin J. Bligh
2004-06-21 7:59 ` Takao Indoh
2004-06-21 8:01 ` Arjan van de Ven
2004-06-22 10:57 ` Takao Indoh
2004-06-21 8:02 ` Christoph Hellwig
2004-06-11 11:41 ` [PATCH 2/4]Diskdump Update Takao Indoh
2004-06-17 12:49 ` Christoph Hellwig
2004-06-17 13:21 ` Takao Indoh
2004-06-17 13:39 ` Christoph Hellwig [this message]
2004-06-22 12:01 ` Takao Indoh
2004-06-22 12:12 ` Christoph Hellwig
2004-06-23 1:47 ` Takao Indoh
2004-06-11 11:42 ` [PATCH 3/4]Diskdump Update Takao Indoh
2004-06-11 11:43 ` [PATCH 4/4]Diskdump Update Takao Indoh
2004-06-14 14:20 ` [PATCH 0/4]Diskdump Update Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040617133906.GA32219@infradead.org \
--to=hch@infradead.org \
--cc=indou.takao@soft.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.