From: Arjan van de Ven <arjanv@redhat.com>
To: Takao Indoh <indou.takao@soft.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4]Diskdump Update
Date: Mon, 21 Jun 2004 10:01:29 +0200 [thread overview]
Message-ID: <20040621080129.GA27569@devserv.devel.redhat.com> (raw)
In-Reply-To: <DBC45765BB709Eindou.takao@soft.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Mon, Jun 21, 2004 at 04:59:52PM +0900, Takao Indoh wrote:
> Hi,
>
> Now I am fixing diskdump according to comments by you and Christoph.
>
> On Fri, 11 Jun 2004 13:50:45 +0200, Arjan van de Ven wrote:
>
> >> +#ifdef CONFIG_PROC_FS
> >> +static int proc_ioctl(struct inode *inode, struct file *file, unsigned
> >> int cmd, unsigned long param)
> >
> >
> >ehhh this looks evil
>
> Do you mean I should use not ioctl but the following style?
>
> echo "add /dev/hda1" > /proc/diskdump
> echo "delete /dev/hda1" > /proc/diskdump
well no since /dev/hda is pointless; major/minor pairs maybe.
But why in /proc???? it sounds like a sysfs job to me, where you probably
want to represent a dump relationship with a symlink, and use "rm" to remove
an entry..
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-21 8:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 11:34 [PATCH 0/4]Diskdump Update Takao Indoh
2004-06-11 11:40 ` [PATCH 1/4]Diskdump Update Takao Indoh
2004-06-11 11:50 ` Arjan van de Ven
2004-06-11 13:40 ` Takao Indoh
2004-06-11 15:17 ` Martin J. Bligh
2004-06-14 1:38 ` Takao Indoh
2004-06-14 2:08 ` Martin J. Bligh
2004-06-21 7:59 ` Takao Indoh
2004-06-21 8:01 ` Arjan van de Ven [this message]
2004-06-22 10:57 ` Takao Indoh
2004-06-21 8:02 ` Christoph Hellwig
2004-06-11 11:41 ` [PATCH 2/4]Diskdump Update Takao Indoh
2004-06-17 12:49 ` Christoph Hellwig
2004-06-17 13:21 ` Takao Indoh
2004-06-17 13:39 ` Christoph Hellwig
2004-06-22 12:01 ` Takao Indoh
2004-06-22 12:12 ` Christoph Hellwig
2004-06-23 1:47 ` Takao Indoh
2004-06-11 11:42 ` [PATCH 3/4]Diskdump Update Takao Indoh
2004-06-11 11:43 ` [PATCH 4/4]Diskdump Update Takao Indoh
2004-06-14 14:20 ` [PATCH 0/4]Diskdump Update Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040621080129.GA27569@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=indou.takao@soft.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.