All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: willy@debian.org, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [2.6 patch] fix arch/i386/pci/Makefile
Date: Thu, 24 Jun 2004 21:01:50 -0700	[thread overview]
Message-ID: <20040624210150.46e68ded.akpm@osdl.org> (raw)
In-Reply-To: <20040625001513.GB18303@fs.tum.de>

Adrian Bunk <bunk@fs.tum.de> wrote:
>
> I got the following compile error in 2.6.7-mm2 (but it doesn't seem to 
>  be specific to -mm2):
> ..
>  drivers/built-in.o(.text+0x6c24a): In function `acpi_pci_root_add':
>  : undefined reference to `pci_acpi_scan_root'
>  make: *** [.tmp_vmlinux1] Error 1

> 
>  This problem occurs with
>    CONFIG_ACPI_PCI=y && (CONFIG_X86_VISWS=y || CONFIG_X86_NUMAQ=y)
> 
> ....
>  --- linux-2.6.7-mm2-full/arch/i386/pci/Makefile.old	2004-06-25 02:08:29.000000000 +0200
>  +++ linux-2.6.7-mm2-full/arch/i386/pci/Makefile	2004-06-25 02:10:36.000000000 +0200
>  @@ -5,10 +5,11 @@
>   obj-$(CONFIG_PCI_DIRECT)	+= direct.o
>   
>   pci-y				:= fixup.o
>  -pci-$(CONFIG_ACPI_PCI)		+= acpi.o
>   pci-y				+= legacy.o irq.o
>   
>   pci-$(CONFIG_X86_VISWS)		:= visws.o fixup.o
>   pci-$(CONFIG_X86_NUMAQ)		:= numa.o irq.o
>   
>  +pci-$(CONFIG_ACPI_PCI)		+= acpi.o
>  +

This causes my e100 NIC to not work.  Some initcall ordering dependency,
presumably.  A whole bunch of devices popped up on different IRQs.

Come to think about it, how can the above patch fix that linkage error
anyway?

  reply	other threads:[~2004-06-25  4:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25  0:15 [2.6 patch] fix arch/i386/pci/Makefile Adrian Bunk
2004-06-25  4:01 ` Andrew Morton [this message]
2004-06-25 22:04   ` Adrian Bunk
2004-06-25 18:01 ` Matthew Wilcox
2004-06-25 22:03   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040624210150.46e68ded.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.