Re: [2.6 patch] fix arch/i386/pci/Makefile

[Adrian Bunk <bunk@fs.tum.de>]

On Thu, Jun 24, 2004 at 09:01:50PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@fs.tum.de> wrote:
> >
> > I got the following compile error in 2.6.7-mm2 (but it doesn't seem to 
> >  be specific to -mm2):
> > ..
> >  drivers/built-in.o(.text+0x6c24a): In function `acpi_pci_root_add':
> >  : undefined reference to `pci_acpi_scan_root'
> >  make: *** [.tmp_vmlinux1] Error 1
> 
> > 
> >  This problem occurs with
> >    CONFIG_ACPI_PCI=y && (CONFIG_X86_VISWS=y || CONFIG_X86_NUMAQ=y)
> > 
> > ....
> >  --- linux-2.6.7-mm2-full/arch/i386/pci/Makefile.old	2004-06-25 02:08:29.000000000 +0200
> >  +++ linux-2.6.7-mm2-full/arch/i386/pci/Makefile	2004-06-25 02:10:36.000000000 +0200
> >  @@ -5,10 +5,11 @@
> >   obj-$(CONFIG_PCI_DIRECT)	+= direct.o
> >   
> >   pci-y				:= fixup.o
> >  -pci-$(CONFIG_ACPI_PCI)		+= acpi.o
> >   pci-y				+= legacy.o irq.o
> >   
> >   pci-$(CONFIG_X86_VISWS)		:= visws.o fixup.o
> >   pci-$(CONFIG_X86_NUMAQ)		:= numa.o irq.o
> >   
> >  +pci-$(CONFIG_ACPI_PCI)		+= acpi.o
> >  +
> 
> This causes my e100 NIC to not work.  Some initcall ordering dependency,
> presumably.  A whole bunch of devices popped up on different IRQs.
> 
> Come to think about it, how can the above patch fix that linkage error
> anyway?

A := overrides all previous := and += .


But Matthew's patch seems to be a better solution.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed