From: linas@austin.ibm.com
To: Greg KH <greg@kroah.com>
Cc: Dave Hansen <haveblue@us.ibm.com>,
paulus@au1.ibm.com, Paul Mackerras <paulus@samba.org>,
PPC64 External List <linuxppc64-dev@lists.linuxppc.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)]
Date: Thu, 1 Jul 2004 16:17:34 -0500 [thread overview]
Message-ID: <20040701161733.J21634@forte.austin.ibm.com> (raw)
In-Reply-To: <20040701203938.GB23260@kroah.com>; from greg@kroah.com on Thu, Jul 01, 2004 at 01:39:38PM -0700
On Thu, Jul 01, 2004 at 01:39:38PM -0700, Greg KH wrote:
>
> And shouldn't you return -ENOMEM if you are out of memory, and can't log
> the message?
The current architected interface for this routine is to return
the error code as generated by firmware, and not an error code that
might be gen'ed during call execution. If we change this convention,
then we'd have to audit all 68 uses of this routine to see if any
are affected, and fix the ones that are. This is a potentially
error-prone process. Also, the likelyhood of having a failed rtas
call is supposed to be very small (ideally never), to hava a failed
call *and* be out of memory to record the failure seems dim ...
the benefit doesn't seem worth it.
--linas
next prev parent reply other threads:[~2004-07-01 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 19:19 [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)] linas
2004-07-01 19:49 ` Dave Hansen
2004-07-01 20:31 ` linas
2004-07-01 20:39 ` Greg KH
2004-07-01 21:17 ` linas [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-29 22:50 [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30 1:44 ` Benjamin Herrenschmidt
2004-06-30 17:36 ` linas
2004-06-30 18:47 ` Benjamin Herrenschmidt
2004-06-30 20:31 ` [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?) linas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040701161733.J21634@forte.austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=greg@kroah.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@au1.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.