From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linas@austin.ibm.com
Cc: paulus@au1.ibm.com, Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@lists.linuxppc.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PPC64: lockfix for rtas error log
Date: Tue, 29 Jun 2004 20:44:26 -0500 [thread overview]
Message-ID: <1088559864.1906.9.camel@gaston> (raw)
In-Reply-To: <20040629175007.P21634@forte.austin.ibm.com>
On Tue, 2004-06-29 at 17:50, linas@austin.ibm.com wrote:
> Paul,
>
> Could you please apply the following path to the ameslab tree, and/or
> forward it to the main 2.6 kernel maintainers.
>
> This patch moves the location of a lock in order to protect
> the contents of a buffer until it has been copied to its final
> destination. Prior to this, a race existed whereby the buffer
> could be filled even while it was being emptied.
Hrm....
That's bad, I moved that out of the lock on purpose to avoid deadlocks,
I think ppc_md.log_error can take the rtas lock again (nvram). We need to
take a separate lock for the err buf if that function can be called
concurrently I suppose.
Ben.
next prev parent reply other threads:[~2004-06-30 1:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-29 22:50 [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30 1:17 ` David Gibson
2004-06-30 16:58 ` linas
2004-06-30 1:44 ` Benjamin Herrenschmidt [this message]
2004-06-30 17:36 ` linas
2004-06-30 18:47 ` Benjamin Herrenschmidt
2004-06-30 19:02 ` Olof Johansson
2004-06-30 19:02 ` Benjamin Herrenschmidt
2004-06-30 20:31 ` [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?) linas
2004-06-30 11:27 ` [PATCH] PPC64: lockfix for rtas error log Paul Mackerras
2004-06-30 17:50 ` linas
2004-06-30 23:07 ` Paul Mackerras
2004-07-01 16:31 ` Jake Moilanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088559864.1906.9.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@au1.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.