All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com
Cc: linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC64: lockfix for rtas error log
Date: Wed, 30 Jun 2004 21:27:09 +1000	[thread overview]
Message-ID: <16610.41869.78636.349800@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20040629175007.P21634@forte.austin.ibm.com>

Linas,

> This patch moves the location of a lock in order to protect
> the contents of a buffer until it has been copied to its final
> destination. Prior to this, a race existed whereby the buffer
> could be filled even while it was being emptied.

Given that log_error() seems to be a no-op at the moment AFAICT, and
that Ben H was concerned about possible deadlocks if log_error
actually did do something, I'd like to see a resolution of (a) what
log_error should be doing and (b) whether there is in fact any
possibility of deadlock with this patch once (a) is resolved.

Thanks,
Paul.

  parent reply	other threads:[~2004-06-30 11:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-29 22:50 [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30  1:17 ` David Gibson
2004-06-30 16:58   ` linas
2004-06-30  1:44 ` Benjamin Herrenschmidt
2004-06-30 17:36   ` linas
2004-06-30 18:47     ` Benjamin Herrenschmidt
2004-06-30 19:02       ` Olof Johansson
2004-06-30 19:02         ` Benjamin Herrenschmidt
2004-06-30 20:31       ` [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?) linas
2004-06-30 11:27 ` Paul Mackerras [this message]
2004-06-30 17:50   ` [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30 23:07     ` Paul Mackerras
2004-07-01 16:31       ` Jake Moilanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16610.41869.78636.349800@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.