From: Olof Johansson <olof@austin.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linas@austin.ibm.com, paulus@au1.ibm.com,
Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@lists.linuxppc.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PPC64: lockfix for rtas error log
Date: Wed, 30 Jun 2004 14:02:40 -0500 [thread overview]
Message-ID: <40E30E50.3040401@austin.ibm.com> (raw)
In-Reply-To: <1088621248.1920.43.camel@gaston>
Benjamin Herrenschmidt wrote:
>> So instead, the problem can be easily
>>avoided by not using a global buffer. The code below mallocs/frees.
>>Its not perf-critcal, so I don't mind malloc overhead. Would this
>>work for you? Patch attached below.
>
>
> I prefer that, but couldn't we move the kmalloc outside of the spinlock
> and so use GFP_KERNEL instead ?
Isn't the global buffer used since it's in BSS, and as such, in low
memory, guaranteed to be below 4GB? RTAS has limitations that restricts
any passed-in buffers to be addressable as 32-bit real mode pointers, right?
-Olof
next prev parent reply other threads:[~2004-06-30 19:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-29 22:50 [PATCH] PPC64: lockfix for rtas error log linas
2004-06-30 1:17 ` David Gibson
2004-06-30 16:58 ` linas
2004-06-30 1:44 ` Benjamin Herrenschmidt
2004-06-30 17:36 ` linas
2004-06-30 18:47 ` Benjamin Herrenschmidt
2004-06-30 19:02 ` Olof Johansson [this message]
2004-06-30 19:02 ` Benjamin Herrenschmidt
2004-06-30 20:31 ` [PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?) linas
2004-06-30 11:27 ` [PATCH] PPC64: lockfix for rtas error log Paul Mackerras
2004-06-30 17:50 ` linas
2004-06-30 23:07 ` Paul Mackerras
2004-07-01 16:31 ` Jake Moilanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E30E50.3040401@austin.ibm.com \
--to=olof@austin.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@au1.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.