All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pass unsgined long to udelay in e1000
@ 2004-07-02 18:17 Olaf Hering
  0 siblings, 0 replies; only message in thread
From: Olaf Hering @ 2004-07-02 18:17 UTC (permalink / raw)
  To: cramerj, netdev


I get these warnings on ppc32 due to the check in udelay() macro.
Is it safe to move the struct member?


  CC [M]  drivers/net/e1000/e1000_hw.o
drivers/net/e1000/e1000_hw.c: In function `e1000_raise_ee_clk':
drivers/net/e1000/e1000_hw.c:3122: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_lower_ee_clk':
drivers/net/e1000/e1000_hw.c:3141: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_shift_out_ee_bits':
drivers/net/e1000/e1000_hw.c:3185: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_standby_eeprom':
drivers/net/e1000/e1000_hw.c:3314: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3320: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3326: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3332: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3338: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3342: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_release_eeprom':
drivers/net/e1000/e1000_hw.c:3366: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3379: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3385: warning: comparison is always false due to limited range of data type


patch is against 2.6.7-bk15


--- ./drivers/net/e1000/e1000_hw.h
+++ ./drivers/net/e1000/e1000_hw.h	2004/07/02 18:07:28
@@ -234,8 +234,8 @@ struct e1000_eeprom_info {
     uint16_t word_size;
     uint16_t opcode_bits;
     uint16_t address_bits;
-    uint16_t delay_usec;
     uint16_t page_size;
+    unsigned long delay_usec;
 };
 
 

-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-07-02 18:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-02 18:17 [PATCH] pass unsgined long to udelay in e1000 Olaf Hering

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.