* [PATCH] SPLPAR spinlock optimisation
@ 2004-07-04 10:11 Anton Blanchard
0 siblings, 0 replies; only message in thread
From: Anton Blanchard @ 2004-07-04 10:11 UTC (permalink / raw)
To: akpm; +Cc: paulus, linux-kernel
Currently our spinlocks can call into the hypervisor on dedicated
processor machines. Doing this may slow our locks down, so avoid it
where possible.
Signed-off-by: Anton Blanchard <anton@samba.org>
diff -puN arch/ppc64/lib/locks.c~splpar_speedup arch/ppc64/lib/locks.c
--- foobar2/arch/ppc64/lib/locks.c~splpar_speedup 2004-07-04 19:40:39.518987541 +1000
+++ foobar2-anton/arch/ppc64/lib/locks.c 2004-07-04 19:55:27.966154716 +1000
@@ -38,6 +38,10 @@
/* waiting for a spinlock... */
#if defined(CONFIG_PPC_SPLPAR) || defined(CONFIG_PPC_ISERIES)
+
+/* We only yield to the hypervisor if we are in shared processor mode */
+#define SHARED_PROCESSOR (get_paca()->lppaca.xSharedProc)
+
void __spin_yield(spinlock_t *lock)
{
unsigned int lock_value, holder_cpu, yield_count;
@@ -65,6 +69,7 @@ void __spin_yield(spinlock_t *lock)
#else /* SPLPAR || ISERIES */
#define __spin_yield(x) barrier()
+#define SHARED_PROCESSOR 0
#endif
/*
@@ -104,7 +109,8 @@ void _raw_spin_lock(spinlock_t *lock)
break;
do {
HMT_low();
- __spin_yield(lock);
+ if (SHARED_PROCESSOR)
+ __spin_yield(lock);
} while (likely(lock->lock != 0));
HMT_medium();
}
@@ -123,7 +129,8 @@ void _raw_spin_lock_flags(spinlock_t *lo
local_irq_restore(flags);
do {
HMT_low();
- __spin_yield(lock);
+ if (SHARED_PROCESSOR)
+ __spin_yield(lock);
} while (likely(lock->lock != 0));
HMT_medium();
local_irq_restore(flags_dis);
@@ -134,8 +141,12 @@ EXPORT_SYMBOL(_raw_spin_lock_flags);
void spin_unlock_wait(spinlock_t *lock)
{
- while (lock->lock)
- __spin_yield(lock);
+ while (lock->lock) {
+ HMT_low();
+ if (SHARED_PROCESSOR)
+ __spin_yield(lock);
+ }
+ HMT_medium();
}
EXPORT_SYMBOL(spin_unlock_wait);
@@ -213,7 +224,8 @@ void _raw_read_lock(rwlock_t *rw)
break;
do {
HMT_low();
- __rw_yield(rw);
+ if (SHARED_PROCESSOR)
+ __rw_yield(rw);
} while (likely(rw->lock < 0));
HMT_medium();
}
@@ -275,7 +287,8 @@ void _raw_write_lock(rwlock_t *rw)
break;
do {
HMT_low();
- __rw_yield(rw);
+ if (SHARED_PROCESSOR)
+ __rw_yield(rw);
} while (likely(rw->lock != 0));
HMT_medium();
}
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-07-04 10:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-04 10:11 [PATCH] SPLPAR spinlock optimisation Anton Blanchard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.