[PATCH] MIPS getdomainname() off by 1;

[PATCH] MIPS getdomainname() off by 1;

[Randy.Dunlap]

irix_getdomainname() max size appears to be off by 1;
other similar code in kernel uses __NEW_UTS_LEN as the max size,
and <domainname> includes an extra byte for the terminating
null character.

Does sysirix.c need to limit <len> to 63 instead of 64 for some
reason?


diffstat:=
 arch/mips/kernel/sysirix.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff -Naurp ./arch/mips/kernel/sysirix.c~uts_len_off1 ./arch/mips/kernel/sysirix.c
--- ./arch/mips/kernel/sysirix.c~uts_len_off1	2004-05-31 13:58:24.000000000 -0700
+++ ./arch/mips/kernel/sysirix.c	2004-05-31 20:11:42.000000000 -0700
@@ -913,8 +913,8 @@ asmlinkage int irix_getdomainname(char *
 		return error;
 
 	down_read(&uts_sem);
-	if(len > (__NEW_UTS_LEN - 1))
-		len = __NEW_UTS_LEN - 1;
+	if (len > __NEW_UTS_LEN)
+		len = __NEW_UTS_LEN;
 	error = 0;
 	if (copy_to_user(name, system_utsname.domainname, len))
 		error = -EFAULT;

--
~Randy

Re: [PATCH] MIPS getdomainname() off by 1;

[Ralf Baechle]

On Mon, May 31, 2004 at 08:21:01PM -0700, Randy.Dunlap wrote:

> irix_getdomainname() max size appears to be off by 1;
> other similar code in kernel uses __NEW_UTS_LEN as the max size,
> and <domainname> includes an extra byte for the terminating
> null character.
> 
> Does sysirix.c need to limit <len> to 63 instead of 64 for some
> reason?

I would know why - and it has other bugs also, so I removed it by the
normal Linux getdomainname(2) for SysV flavour syscalls, too.

  Ralf

Re: [PATCH] MIPS getdomainname() off by 1;

[Geert Uytterhoeven]

On Thu, 8 Jul 2004, Ralf Baechle wrote:
> On Mon, May 31, 2004 at 08:21:01PM -0700, Randy.Dunlap wrote:
> > irix_getdomainname() max size appears to be off by 1;
> > other similar code in kernel uses __NEW_UTS_LEN as the max size,
> > and <domainname> includes an extra byte for the terminating
> > null character.
> >
> > Does sysirix.c need to limit <len> to 63 instead of 64 for some
> > reason?
>
> I would know why - and it has other bugs also, so I removed it by the
> normal Linux getdomainname(2) for SysV flavour syscalls, too.

I saw you even removed it from 2.0. Woow! ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] MIPS getdomainname() off by 1;

[Ralf Baechle]

On Thu, Jul 08, 2004 at 10:46:19AM +0200, Geert Uytterhoeven wrote:

> > > Does sysirix.c need to limit <len> to 63 instead of 64 for some
> > > reason?
> >
> > I would know why - and it has other bugs also, so I removed it by the
> > normal Linux getdomainname(2) for SysV flavour syscalls, too.
> 
> I saw you even removed it from 2.0. Woow! ;-)

Yep :-)  But whoever is still runing 2.0 on MIPS must be suffering from a
suicidal tendences.  Too many bugs left unfixed.

  Ralf