Re: [Kernel-janitors] [PATCH] IO-APIC debug message reducti

From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] IO-APIC debug message reducti
Date: Sun, 11 Jul 2004 10:38:35 +0000	[thread overview]
Message-ID: <20040711103835.GB10133@sputnik.stro.at> (raw)
In-Reply-To: <1089145628.2957.9.camel@tigger>

[-- Attachment #1: Type: text/plain, Size: 1872 bytes --]

On Sat, 10 Jul 2004, Mark Broadbent wrote:

> Hi,
> 
> > IOAPIC_DEBUG should also activate the Dprintk() statements normally
> > activated via editing include/asm-i386/apic.h:
> > 
> > #define APIC_DEBUG 0
> 
> Expanded the output reduction to covert the Dprintk's in apic.c to
> apic_printk.  Rediffed and attached.
> 
> Thanks
> Mark
> 
> Index: linux-2.6.7/arch/i386/kernel/io_apic.c
> ===================================================================
> --- linux-2.6.7/arch/i386/kernel/io_apic.c	(revision 1)
> +++ linux-2.6.7/arch/i386/kernel/io_apic.c	(working copy)
..
> @@ -1339,6 +1351,9 @@
>  	union IO_APIC_reg_03 reg_03;
>  	unsigned long flags;
>  
> +	if (apic_verbosity == APIC_QUIET)
> +		return;
> +		
>   	printk(KERN_DEBUG "number of MP IRQ sources: %d.\n", mp_irq_entries);
>  	for (i = 0; i < nr_ioapics; i++)
>  		printk(KERN_DEBUG "number of IO-APIC #%d registers: %d.\n",

that looks scary, did you actually test your changes?
looks like a big change to print_IO_APIC()

please when rediffing please use the -p switch from diff(1)
as explained in Documentation/SubmittingPatches

> @@ -1476,6 +1491,9 @@
>  	unsigned int v;
>  	int i, j;
>  
> +	if (apic_verbosity == APIC_QUIET)
> +		return;
> +		
>  	printk(KERN_DEBUG "0123456789abcdef0123456789abcdef\n" KERN_DEBUG);
>  	for (i = 0; i < 8; i++) {
>  		v = apic_read(base + i*0x10);
> @@ -1493,6 +1511,9 @@
>  {
>  	unsigned int v, ver, maxlvt;
>  
> +	if (apic_verbosity == APIC_QUIET)
> +		return;
> +		
>  	printk("\n" KERN_DEBUG "printing local APIC contents on CPU#%d/%d:\n",
>  		smp_processor_id(), hard_smp_processor_id());
>  	v = apic_read(APIC_ID);
> @@ -1580,6 +1601,9 @@
>  	unsigned int v;
>  	unsigned long flags;
>  
> +	if (apic_verbosity == APIC_QUIET)
> +		return;
> +		
>  	printk(KERN_DEBUG "\nprinting PIC contents\n");
>  
>  	spin_lock_irqsave(&i8259A_lock, flags);
..

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors