All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] IO-APIC debug message reducti
Date: Tue, 13 Jul 2004 19:27:10 +0000	[thread overview]
Message-ID: <40F4378E.7010707@pobox.com> (raw)
In-Reply-To: <1089145628.2957.9.camel@tigger>

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

Mark Broadbent wrote:
> --- linux-2.6.7/arch/i386/kernel/apic.c	(revision 1)
> +++ linux-2.6.7/arch/i386/kernel/apic.c	(working copy)
> @@ -40,6 +40,15 @@
>  
>  #include "io_ports.h"
>  
> +/* 
> + * Debug level
> + */
> +extern int apic_verbosity;
> +
> +/* Ensure io_apic can see this level as well */
> +EXPORT_SYMBOL(apic_verbosity);


Your patch looks OK to me except for one small bit, above.

First, you should put the 'extern int apic_verbosity' in a header, 
presumeably the same header into which you stashed 
APIC_{QUIET,VERBOSE,DEBUG} definitions.

Second, it is highly unlikely that this symbol should be exported to 
kernel modules.

	Jeff



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-07-13 19:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-06 20:27 [Kernel-janitors] [PATCH] IO-APIC debug message reduction at Mark Broadbent
2004-07-07  0:25 ` Arnaldo Carvalho de Melo
2004-07-07 20:29 ` Re: [Kernel-janitors] [PATCH] IO-APIC debug message reducti Mark Broadbent
2004-07-07 21:03 ` Randy.Dunlap
2004-07-07 21:11 ` Luiz Fernando N. Capitulino
2004-07-08 18:45 ` Mark Broadbent
2004-07-08 23:09 ` Jeff Garzik
2004-07-10  0:56 ` Mark Broadbent
2004-07-11 10:38 ` maximilian attems
2004-07-13 19:20 ` Mark Broadbent
2004-07-13 19:27 ` Jeff Garzik [this message]
2004-07-14  5:24 ` Randy.Dunlap
2004-07-14  8:04 ` Mark Broadbent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40F4378E.7010707@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.