[uml-devel] Could you explain this strange fix?

[uml-devel] Could you explain this strange fix?

[BlaisorBlade]

This hunk comes straight from 2.4.24-3um. Could you explain it? Are you sure 
it's safe? Several people complain about patches later than 2.4.24-1 (even 
for stability), so I have doubts about it. Also, could you say me which is 
the fix for the "tracing myself" bug of 2.4? The patch is in 2.4.24-2, but 
since I've split it out, I cannot find which is the needed fix.

diff -puN arch/um/kernel/skas/tlb.c~optimization-unstable 
arch/um/kernel/skas/tlb.c
--- UmWorklinux-2.4.24/arch/um/kernel/skas/tlb.c~optimization-unstable  
2004-07-02 13:45:07.057643968 +0200
+++ UmWorklinux-2.4.24-paolo/arch/um/kernel/skas/tlb.c  2004-07-02 
13:45:14.098573584 +0200
@@ -132,7 +132,9 @@ void flush_tlb_range_skas(struct mm_stru

 void flush_tlb_mm_skas(struct mm_struct *mm)
 {
+#if 0
        flush_tlb_kernel_vm_skas();
+#endif
        fix_range(mm, 0, host_task_size, 0);
 }


-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Could you explain this strange fix?

[BlaisorBlade]

Alle 20:55, sabato 3 luglio 2004, BlaisorBlade ha scritto:
> This hunk comes straight from 2.4.24-3um. Could you explain it? Are you
> sure it's safe? Several people complain about patches later than 2.4.24-1
> (even for stability), so I have doubts about it.
And I've also been confirmed that it is the cause of iptables not working in 
2.4.26. I'm going to forward you the mail.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Could you explain this strange fix?

[Jeff Dike]

blaisorblade_spam@yahoo.it said:
> This hunk comes straight from 2.4.24-3um. Could you explain it? 

It showed up when I was doing profiling.  I looked at it and decided it was
a tt mode holdover, since when you flush a process address space in skas mode, 
that normally doesn't need to look at the kernel's address space.

> Are you sure  it's safe?

I was, but I forgot about modules.

				Jeff



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel