All of lore.kernel.org
 help / color / mirror / Atom feed
* [Kernel-janitors] [PATCH] he: replace schedule_timeout() with
@ 2004-07-19 21:15 Nishanth Aravamudan
  0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-07-19 21:15 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

I would appreciate any comments from the janitors list. If this is ok, I
have many more with similar fixes.

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- linux-vanilla/drivers/atm/he.c	2004-06-16 05:18:59.000000000 +0000
+++ linux-dev/drivers/atm/he.c	2004-07-02 17:19:27.000000000 +0000
@@ -2595,8 +2595,7 @@ he_close(struct atm_vcc *vcc)
 
 		while (((tx_inuse = atomic_read(&vcc->sk->sk_wmem_alloc)) > 0) &&
 		       (retry < MAX_RETRY)) {
-			set_current_state(TASK_UNINTERRUPTIBLE);
-			(void) schedule_timeout(sleep);
+			msleep(jiffies_to_msecs(sleep));
 			if (sleep < HZ)
 				sleep = sleep * 2;
 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-07-19 21:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-19 21:15 [Kernel-janitors] [PATCH] he: replace schedule_timeout() with Nishanth Aravamudan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.