* [Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with
@ 2004-07-19 21:44 Nishanth Aravamudan
2004-07-21 21:19 ` Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-07-19 21:44 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/block/nbd.c 2004-06-16 05:19:01.000000000 +0000
+++ linux-dev/drivers/block/nbd.c 2004-07-02 17:24:31.000000000 +0000
@@ -139,8 +139,7 @@ static void nbd_end_request(struct reque
spin_unlock(&lo->queue_lock);
printk(KERN_DEBUG "%s: request %p still in use (%d), waiting\n",
lo->disk->disk_name, req, req->ref_count);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ); /* wait a second */
+ msleep(1000);
spin_lock(&lo->queue_lock);
}
spin_unlock(&lo->queue_lock);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with
2004-07-19 21:44 [Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with Nishanth Aravamudan
@ 2004-07-21 21:19 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 21:19 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
Please find below the corrected patch, as the previous one would not
compile. Thanks.
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/block/nbd.c 2004-06-16 05:19:01.000000000 +0000
+++ linux-dev/drivers/block/nbd.c 2004-07-21 16:51:48.000000000 +0000
@@ -54,6 +54,7 @@
#include <linux/errno.h>
#include <linux/file.h>
#include <linux/ioctl.h>
+#include <linux/delay.h>
#include <net/sock.h>
#include <linux/devfs_fs_kernel.h>
@@ -139,8 +140,7 @@ static void nbd_end_request(struct reque
spin_unlock(&lo->queue_lock);
printk(KERN_DEBUG "%s: request %p still in use (%d), waiting\n",
lo->disk->disk_name, req, req->ref_count);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ); /* wait a second */
+ msleep(1000);
spin_lock(&lo->queue_lock);
}
spin_unlock(&lo->queue_lock);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-21 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-19 21:44 [Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with Nishanth Aravamudan
2004-07-21 21:19 ` Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.