* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout()
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
@ 2004-07-20 18:20 ` Nishanth Aravamudan
2004-07-20 18:20 ` Nishanth Aravamudan
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-20 18:20 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/bt3c_cs.c 2004-06-16 05:20:26.000000000 +0000
+++ linux-dev/drivers/bluetooth/bt3c_cs.c 2004-07-10 18:23:11.000000000 +0000
@@ -633,8 +633,7 @@ int bt3c_open(bt3c_info_t *info)
}
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
/* Register HCI device */
err = hci_register_dev(hdev);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout()
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
2004-07-20 18:20 ` Nishanth Aravamudan
@ 2004-07-20 18:20 ` Nishanth Aravamudan
2004-07-20 18:21 ` Nishanth Aravamudan
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-20 18:20 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/btuart_cs.c 2004-06-16 05:20:26.000000000 +0000
+++ linux-dev/drivers/bluetooth/btuart_cs.c 2004-07-10 18:23:17.000000000 +0000
@@ -545,8 +545,7 @@ int btuart_open(btuart_info_t *info)
btuart_change_speed(info, DEFAULT_BAUD_RATE);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout()
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
2004-07-20 18:20 ` Nishanth Aravamudan
2004-07-20 18:20 ` Nishanth Aravamudan
@ 2004-07-20 18:21 ` Nishanth Aravamudan
2004-07-21 21:13 ` [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with Nishanth Aravamudan
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-20 18:21 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/dtl1_cs.c 2004-06-16 05:19:13.000000000 +0000
+++ linux-dev/drivers/bluetooth/dtl1_cs.c 2004-07-10 18:23:26.000000000 +0000
@@ -524,8 +524,7 @@ int dtl1_open(dtl1_info_t *info)
spin_unlock_irqrestore(&(info->lock), flags);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ * 2);
+ msleep(2000);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
` (2 preceding siblings ...)
2004-07-20 18:21 ` Nishanth Aravamudan
@ 2004-07-21 21:13 ` Nishanth Aravamudan
2004-07-21 21:16 ` Nishanth Aravamudan
2004-07-21 21:18 ` Nishanth Aravamudan
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 21:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
Please find below the corrected version, which compiles without error
for me.
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
+++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-21 20:52:07.000000000 +0000
@@ -34,6 +34,7 @@
#include <linux/ioport.h>
#include <linux/spinlock.h>
#include <linux/skbuff.h>
+#include <linux/delay.h>
#include <asm/io.h>
#include <pcmcia/version.h>
@@ -776,8 +777,7 @@ int bluecard_open(bluecard_info_t *info)
outb(0x80, iobase + 0x30);
/* Wait some time */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ / 100);
+ msleep(100);
/* Turn FPGA on */
outb(0x00, iobase + 0x30);
@@ -823,8 +823,7 @@ int bluecard_open(bluecard_info_t *info)
outb((0x0f << RTS_LEVEL_SHIFT_BITS) | 1, iobase + REG_RX_CONTROL);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout((HZ * 5) / 4); // or set it to 3/2
+ msleep(1250);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
` (3 preceding siblings ...)
2004-07-21 21:13 ` [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with Nishanth Aravamudan
@ 2004-07-21 21:16 ` Nishanth Aravamudan
2004-07-21 21:18 ` Nishanth Aravamudan
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 21:16 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
Please find below the corrected version, which compiles without error
for me.
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/btuart_cs.c 2004-06-16 05:20:26.000000000 +0000
+++ linux-dev/drivers/bluetooth/btuart_cs.c 2004-07-21 16:54:09.000000000 +0000
@@ -32,7 +32,7 @@
#include <linux/ptrace.h>
#include <linux/ioport.h>
#include <linux/spinlock.h>
-
+#include <linux/delay.h>
#include <linux/skbuff.h>
#include <linux/string.h>
#include <linux/serial.h>
@@ -545,8 +545,7 @@ int btuart_open(btuart_info_t *info)
btuart_change_speed(info, DEFAULT_BAUD_RATE);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with
2004-07-20 18:18 [Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() Nishanth Aravamudan
` (4 preceding siblings ...)
2004-07-21 21:16 ` Nishanth Aravamudan
@ 2004-07-21 21:18 ` Nishanth Aravamudan
5 siblings, 0 replies; 7+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 21:18 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
Please find below the corrected version, which compiles without error
for me.
I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/bluetooth/dtl1_cs.c 2004-06-16 05:19:13.000000000 +0000
+++ linux-dev/drivers/bluetooth/dtl1_cs.c 2004-07-21 16:53:03.000000000 +0000
@@ -32,7 +32,7 @@
#include <linux/ptrace.h>
#include <linux/ioport.h>
#include <linux/spinlock.h>
-
+#include <linux/delay.h>
#include <linux/skbuff.h>
#include <linux/string.h>
#include <linux/serial.h>
@@ -524,8 +524,7 @@ int dtl1_open(dtl1_info_t *info)
spin_unlock_irqrestore(&(info->lock), flags);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ * 2);
+ msleep(2000);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread