All of lore.kernel.org
 help / color / mirror / Atom feed
* [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout()
@ 2004-07-20 20:58 Nishanth Aravamudan
  2004-07-21 21:20 ` Nishanth Aravamudan
  2004-09-01 22:19 ` [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() with Nishanth Aravamudan
  0 siblings, 2 replies; 3+ messages in thread
From: Nishanth Aravamudan @ 2004-07-20 20:58 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- linux-vanilla/drivers/cdrom/sonycd535.c	2004-06-16 05:19:11.000000000 +0000
+++ linux-dev/drivers/cdrom/sonycd535.c	2004-07-10 18:29:01.000000000 +0000
@@ -1478,8 +1478,7 @@ static int __init sony535_init(void)
 	/* look for the CD-ROM, follows the procedure in the DOS driver */
 	inb(select_unit_reg);
 	/* wait for 40 18 Hz ticks (reverse-engineered from DOS driver) */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout((HZ+17)*40/18);
+	msleep(2223);
 	inb(result_reg);
 
 	outb(0, read_status_reg);	/* does a reset? */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout()
  2004-07-20 20:58 [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() Nishanth Aravamudan
@ 2004-07-21 21:20 ` Nishanth Aravamudan
  2004-09-01 22:19 ` [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() with Nishanth Aravamudan
  1 sibling, 0 replies; 3+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 21:20 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

Please find below the corrected patch, as the previous one would not
compile.

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- linux-vanilla/drivers/cdrom/sonycd535.c	2004-06-16 05:19:11.000000000 +0000
+++ linux-dev/drivers/cdrom/sonycd535.c	2004-07-21 16:54:55.000000000 +0000
@@ -129,7 +129,8 @@
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/init.h>
-
+#include <linux/delay.h>
+ 
 #define REALLY_SLOW_IO
 #include <asm/system.h>
 #include <asm/io.h>
@@ -1478,8 +1479,7 @@ static int __init sony535_init(void)
 	/* look for the CD-ROM, follows the procedure in the DOS driver */
 	inb(select_unit_reg);
 	/* wait for 40 18 Hz ticks (reverse-engineered from DOS driver) */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout((HZ+17)*40/18);
+	msleep(2223);
 	inb(result_reg);
 
 	outb(0, read_status_reg);	/* does a reset? */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() with
  2004-07-20 20:58 [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() Nishanth Aravamudan
  2004-07-21 21:20 ` Nishanth Aravamudan
@ 2004-09-01 22:19 ` Nishanth Aravamudan
  1 sibling, 0 replies; 3+ messages in thread
From: Nishanth Aravamudan @ 2004-09-01 22:19 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

This is one of 10 patches which have either not been pushed to mainline
(2.6.9-rc1-bk7) or have not been included in any of the recent kjt's.

Applys-to: 2.6.9-rc1-bk7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- 2.6.9-rc1-bk7-vanilla/drivers/cdrom/sonycd535.c	2004-08-31 21:26:50.000000000 +0000
+++ 2.6.9-rc1-bk7-dev/drivers/cdrom/sonycd535.c	2004-09-01 21:38:39.000000000 +0000
@@ -129,6 +129,7 @@
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/init.h>
+#include <linux/delay.h>
 
 #define REALLY_SLOW_IO
 #include <asm/system.h>
@@ -1478,8 +1479,7 @@ static int __init sony535_init(void)
 	/* look for the CD-ROM, follows the procedure in the DOS driver */
 	inb(select_unit_reg);
 	/* wait for 40 18 Hz ticks (reverse-engineered from DOS driver) */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout((HZ+17)*40/18);
+	msleep(2223);
 	inb(result_reg);
 
 	outb(0, read_status_reg);	/* does a reset? */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-01 22:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-20 20:58 [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() Nishanth Aravamudan
2004-07-21 21:20 ` Nishanth Aravamudan
2004-09-01 22:19 ` [Kernel-janitors] [PATCH] sonycd535: replace schedule_timeout() with Nishanth Aravamudan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.