From: Paul Jackson <pj@sgi.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [RFC] Patch for isolated scheduler domains
Date: Thu, 22 Jul 2004 19:34:37 +0000 [thread overview]
Message-ID: <20040722123437.1f0398db.pj@sgi.com> (raw)
In-Reply-To: <20040722164126.GB13189@sgi.com>
You should double check my logic, but I think a couple of the cpumask
calculations can be tightened up, as follows.
Dimitri Sivanich <sivanich@sgi.com> wrote:
>
> + cpumask_t cpu_nonisolated;
> +
> + cpus_and(cpu_nonisolated, cpu_possible_map, isol_cpumask);
> + cpus_complement(cpu_nonisolated, cpu_nonisolated);
> + cpus_and(cpu_nonisolated, cpu_nonisolated, cpu_possible_map);
cpumask_t cpu_nonisolated;
cpus_andnot(cpu_nonisolated, cpu_possible_map, isol_cpumas);
> + cpumask_t tmp = node_to_cpumask(i);
> + cpumask_t nodemask;
> + ...
> + cpus_and(nodemask, tmp, cpu_nonisolated);
cpumask_t nodemask;
...
cpus_and(nodemask, node_to_cpumask(i), cpu_nonisolated);
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [RFC] Patch for isolated scheduler domains
Date: Thu, 22 Jul 2004 12:34:37 -0700 [thread overview]
Message-ID: <20040722123437.1f0398db.pj@sgi.com> (raw)
In-Reply-To: <20040722164126.GB13189@sgi.com>
You should double check my logic, but I think a couple of the cpumask
calculations can be tightened up, as follows.
Dimitri Sivanich <sivanich@sgi.com> wrote:
>
> + cpumask_t cpu_nonisolated;
> +
> + cpus_and(cpu_nonisolated, cpu_possible_map, isol_cpumask);
> + cpus_complement(cpu_nonisolated, cpu_nonisolated);
> + cpus_and(cpu_nonisolated, cpu_nonisolated, cpu_possible_map);
cpumask_t cpu_nonisolated;
cpus_andnot(cpu_nonisolated, cpu_possible_map, isol_cpumas);
> + cpumask_t tmp = node_to_cpumask(i);
> + cpumask_t nodemask;
> + ...
> + cpus_and(nodemask, tmp, cpu_nonisolated);
cpumask_t nodemask;
...
cpus_and(nodemask, node_to_cpumask(i), cpu_nonisolated);
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2004-07-22 19:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-22 16:41 [RFC] Patch for isolated scheduler domains Dimitri Sivanich
2004-07-22 16:41 ` Dimitri Sivanich
2004-07-22 17:54 ` Ingo Molnar
2004-07-22 17:54 ` Ingo Molnar
2004-07-23 3:27 ` Nick Piggin
2004-07-23 3:27 ` Nick Piggin
2004-07-23 4:13 ` Dimitri Sivanich
2004-07-23 4:13 ` Dimitri Sivanich
2004-07-23 4:29 ` Nick Piggin
2004-07-23 4:29 ` Nick Piggin
2004-07-22 19:34 ` Paul Jackson [this message]
2004-07-22 19:34 ` Paul Jackson
2004-07-23 20:03 ` Jesse Barnes
2004-07-24 5:26 ` Nick Piggin
2004-07-24 15:40 ` Jesse Barnes
2004-07-25 4:26 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722123437.1f0398db.pj@sgi.com \
--to=pj@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.