From: Matt Domsch <Matt_Domsch@dell.com>
To: Matthew Wilcox <willy@debian.org>
Cc: linux-scsi@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [3/3] add MODULE_VERSION to drivers/scsi
Date: Thu, 22 Jul 2004 08:38:55 -0500 [thread overview]
Message-ID: <20040722133855.GA30314@lists.us.dell.com> (raw)
In-Reply-To: <20040722122823.GC4227@parcelfarce.linux.theplanet.co.uk>
On Thu, Jul 22, 2004 at 01:28:23PM +0100, Matthew Wilcox wrote:
> > +#define SYM_VERSION "2.1.18j"
> > +#define SYM_DRIVER_NAME "sym-" SYM_VERSION
>
> Umm. No. This is ridiculous. I'm not having a 51 line copyright message
> with 2 lines of #define. It's not even clear to me that these two lines
> have artisitic merit. How about putting these defines in sym_defs.h,
> at the top? It's already included in both sym_glue.c and sym_hipd.c by
> being included by sym_glue.h.
Indeed, point well taken. Done, they're now at the top of defines in
sym_defs.h, and I've updated my BK tree accordingly.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2004-07-22 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 22:01 [0/3] add MODULE_VERSION to drivers/scsi Matt Domsch
2004-07-21 22:02 ` [1/3] " Matt Domsch
2004-07-21 22:02 ` [2/3] " Matt Domsch
2004-07-21 22:02 ` [3/3] " Matt Domsch
2004-07-22 12:28 ` Matthew Wilcox
2004-07-22 13:38 ` Matt Domsch [this message]
2004-07-22 14:07 ` Matt Domsch
2004-07-22 19:02 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722133855.GA30314@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.