From: Benjamin LaHaise <bcrl@kvack.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH] net/ns83820: replace
Date: Tue, 27 Jul 2004 18:34:08 +0000 [thread overview]
Message-ID: <20040727183408.GA3629@kvack.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
The commit message doesn't seem correspond to the actual patch. What
are you trying to "fix"?
-ben
On Tue, Jul 27, 2004 at 11:30:00AM -0700, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list.
>
> Applys-to: 2.6.7
>
> Description: Replace schedule_timeout() with msleep() to guarantee the
> task delays for the desired time.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
>
> --- linux-vanilla/drivers/net/ns83820.c 2004-06-16 05:20:04.000000000 +0000
> +++ linux-dev/drivers/net/ns83820.c 2004-07-08 20:58:27.000000000 +0000
> @@ -1959,7 +1959,7 @@ static int __devinit ns83820_init_one(st
> printk(KERN_INFO "%s: resetting phy\n", ndev->name);
> writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
> set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout((HZ+99)/100);
> + schedule_timeout(10);
> writel(dev->CFG_cache, dev->base + CFG);
> }
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-ns83820' in
> the body to majordomo@kvack.org.
>
--
"Time is what keeps everything from happening all at once." -- John Wheeler
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-07-27 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 18:34 Benjamin LaHaise [this message]
2004-07-27 18:48 ` [Kernel-janitors] Re: [PATCH] net/ns83820: replace Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040727183408.GA3629@kvack.org \
--to=bcrl@kvack.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.