[Kernel-janitors] Re: [PATCH] net/ns83820: replace

[Kernel-janitors] Re: [PATCH] net/ns83820: replace

[Benjamin LaHaise]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

The commit message doesn't seem correspond to the actual patch.  What 
are you trying to "fix"?

		-ben

On Tue, Jul 27, 2004 at 11:30:00AM -0700, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. 
> 
> Applys-to: 2.6.7
> 
> Description: Replace schedule_timeout() with msleep() to guarantee the
> task delays for the desired time.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> 
> --- linux-vanilla/drivers/net/ns83820.c	2004-06-16 05:20:04.000000000 +0000
> +++ linux-dev/drivers/net/ns83820.c	2004-07-08 20:58:27.000000000 +0000
> @@ -1959,7 +1959,7 @@ static int __devinit ns83820_init_one(st
>  		printk(KERN_INFO "%s: resetting phy\n", ndev->name);
>  		writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
>  		set_current_state(TASK_UNINTERRUPTIBLE);
> -		schedule_timeout((HZ+99)/100);
> +		schedule_timeout(10);
>  		writel(dev->CFG_cache, dev->base + CFG);
>  	}
>  
> --
> To unsubscribe, send a message with 'unsubscribe linux-ns83820' in
> the body to majordomo@kvack.org.
> 

-- 
"Time is what keeps everything from happening all at once." -- John Wheeler

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH] net/ns83820: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Tue, Jul 27, 2004 at 02:34:08PM -0400, Benjamin LaHaise wrote:
> The commit message doesn't seem correspond to the actual patch.  What 
> are you trying to "fix"?

Thanks for catching this - it was another typo. Please find the
corrected patch below.

-Nish

Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- linux-vanilla/drivers/net/ns83820.c	2004-06-15 22:20:04.000000000 -0700
+++ linux-dev/drivers/net/ns83820.c	2004-07-27 11:45:33.000000000 -0700
@@ -1958,8 +1958,7 @@ static int __devinit ns83820_init_one(st
 	if (reset_phy) {
 		printk(KERN_INFO "%s: resetting phy\n", ndev->name);
 		writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((HZ+99)/100);
+		msleep(10);
 		writel(dev->CFG_cache, dev->base + CFG);
 	}
 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors