[Kernel-janitors] [PATCH] scsi/qla_init: replace schedule_timeout()

[Kernel-janitors] [PATCH] scsi/qla_init: replace schedule_timeout()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

I would appreciate any comments from the janitors list. 

Applys-to: 2.6.7

Description: Use msleep() instead of schedule_timeout() to 
guarantee the task delays for the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- linux-vanilla/drivers/scsi/qla2xxx/qla_init.c	2004-06-16 05:20:03.000000000 +0000
+++ linux-dev/drivers/scsi/qla2xxx/qla_init.c	2004-07-03 03:53:27.000000000 +0000
@@ -963,8 +963,7 @@ qla2x00_fw_ready(scsi_qla_host_t *ha)
 			break;
 
 		/* Delay for a while */
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ / 2);
+		msleep(2000);
 
 		DEBUG3(printk("scsi(%ld): fw_state=%x curr time=%lx.\n",
 		    ha->host_no, fw_state, jiffies));

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] scsi/qla_init: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Error in the patch, corrected below. Thanks, Domen.


Applys-to: 2.6.7

Description: Replaces schedule_timeout() with msleep() to guarantee task
delays as desired.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- linux-vanilla/drivers/scsi/qla2xxx/qla_init.c	2004-06-15 22:20:03.000000000 -0700
+++ linux-dev/drivers/scsi/qla2xxx/qla_init.c	2004-07-27 16:53:25.000000000 -0700
@@ -963,8 +963,7 @@ qla2x00_fw_ready(scsi_qla_host_t *ha)
 			break;
 
 		/* Delay for a while */
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ / 2);
+		msleep(500);
 
 		DEBUG3(printk("scsi(%ld): fw_state=%x curr time=%lx.\n",
 		    ha->host_no, fw_state, jiffies));

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors