[Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry:

From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry:
Date: Thu, 29 Jul 2004 11:43:49 +0000	[thread overview]
Message-ID: <20040729114349.GD2294@masina.coderock.org> (raw)
In-Reply-To: <20040729114250.GB2294@masina.coderock.org>

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

Make code more readable with list_for_each_entry.
(Note that break follows that list_del, so we don't need to use _safe)
Compile tested.


Signed-off-by: Domen Puncer <domen@coderock.org>

--- c/drivers/atm/he.c	Fri Jul 23 16:00:17 2004
+++ list_for_each/drivers/atm/he.c	Wed Jul 28 18:20:14 2004
@@ -1962,7 +1962,7 @@
 	struct he_tpd *tpd;
 	int slot, updated = 0;
 #ifdef USE_TPD_POOL
-	struct list_head *p;
+	struct he_tpd *__tpd;
 #endif
 
 	/* 2.1.6 transmit buffer return queue */
@@ -1977,8 +1977,7 @@
 			TBRQ_MULTIPLE(he_dev->tbrq_head) ? " MULTIPLE" : "");
 #ifdef USE_TPD_POOL
 		tpd = NULL;
-		list_for_each(p, &he_dev->outstanding_tpds) {
-			struct he_tpd *__tpd = list_entry(p, struct he_tpd, entry);
+		list_for_each_entry(__tpd, &he_dev->outstanding_tpds, entry) {
 			if (TPD_ADDR(__tpd->status) == TBRQ_TPD(he_dev->tbrq_head)) {
 				tpd = __tpd;
 				list_del(&__tpd->entry);

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
