From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry:
Date: Thu, 29 Jul 2004 11:46:46 +0000 [thread overview]
Message-ID: <20040729114646.GJ2294@masina.coderock.org> (raw)
In-Reply-To: <20040729114250.GB2294@masina.coderock.org>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Make code more readable with list_for_each_entry_safe.
(Is this a non i386? I can't compile it.)
Signed-off-by: Domen Puncer <domen@coderock.org>
--- c/drivers/usb/host/hc_sl811.c Wed Jun 16 07:19:43 2004
+++ list_for_each/drivers/usb/host/hc_sl811.c Wed Jul 28 18:53:01 2004
@@ -1343,15 +1343,11 @@
*****************************************************************/
static void __exit hci_hcd_cleanup (void)
{
- struct list_head *hci_l;
- hci_t *hci;
+ hci_t *hci, *tmp;
DBGFUNC ("Enter hci_hcd_cleanup\n");
- for (hci_l = hci_hcd_list.next; hci_l != &hci_hcd_list;) {
- hci = list_entry (hci_l, hci_t, hci_hcd_list);
- hci_l = hci_l->next;
+ list_for_each_entry_safe(hci, tmp, &hci_hcd_list, hci_hcd_list)
hc_release_hci (hci);
- }
}
module_init (hci_hcd_init);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-07-29 11:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-29 11:42 [Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry: Domen Puncer
2004-07-29 11:43 ` Domen Puncer
2004-07-29 11:43 ` Domen Puncer
2004-07-29 11:44 ` Domen Puncer
2004-07-29 11:44 ` Domen Puncer
2004-07-29 11:45 ` Domen Puncer
2004-07-29 11:45 ` Domen Puncer
2004-07-29 11:46 ` Domen Puncer
2004-07-29 11:46 ` Domen Puncer [this message]
2004-07-29 11:47 ` Domen Puncer
2004-07-29 11:47 ` Domen Puncer
2004-07-29 11:48 ` Domen Puncer
2004-07-29 11:48 ` Domen Puncer
2004-07-29 11:49 ` [Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry: fs-dquot.c Domen Puncer
2004-07-29 11:49 ` [Kernel-janitors] [patch 2.6.8-rc2] list_for_each_entry: Domen Puncer
2004-07-29 11:50 ` Domen Puncer
2004-07-29 11:50 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729114646.GJ2294@masina.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.