[Kernel-janitors] Re: [PATCH] hotplug/ibmphp: remove long_delay

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp: remove long_delay

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Sorry, I forgot the dependencies...


Applys-to: 2.6.7

Depends-on: Patches replacing long_delay() with msleep() in ibmphp_hpc.c
and ibmphp_core.c.

Description: Remove long_delay().

Signed-off-by: Nishanth Aravmudan <nacc@us.ibm.com>


--- linux-vanilla/drivers/pci/hotplug/ibmphp.h	2004-06-16 05:18:58.000000000 +0000
+++ linux-dev/drivers/pci/hotplug/ibmphp.h	2004-07-09 00:05:07.000000000 +0000
@@ -759,11 +759,5 @@ extern int ibmphp_configure_card (struct
 extern int ibmphp_unconfigure_card (struct slot **, int);
 extern struct hotplug_slot_ops ibmphp_hotplug_slot_ops;
 
-static inline void long_delay (int delay)
-{
-	set_current_state (TASK_INTERRUPTIBLE);
-	schedule_timeout (delay);
-}
-
 #endif				//__IBMPHP_H
 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp_hpc: replace

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Tue, Jul 27, 2004 at 02:47:22PM -0700, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.

Applied, thanks.

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp_core: replace

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Tue, Jul 27, 2004 at 02:46:11PM -0700, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.

Applied, thanks.

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp: remove long_delay

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

On Tue, Jul 27, 2004 at 02:39:01PM -0700, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. 
> 
> 
> 
> Applys-to: 2.6.7
> 
> Description: Remove unused function long_delay().
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Applied, thanks.

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors