From: Dave Jones <davej@redhat.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
cpufreq@www.linux.org.uk
Subject: Re: post-OLS pending cpufreq patches
Date: Tue, 3 Aug 2004 14:37:24 +0100 [thread overview]
Message-ID: <20040803133724.GM12724@redhat.com> (raw)
In-Reply-To: <20040803133010.GA9447@dominikbrodowski.de>
On Tue, Aug 03, 2004 at 03:30:10PM +0200, Dominik Brodowski wrote:
> On Tue, Aug 03, 2004 at 02:17:29PM +0100, Dave Jones wrote:
> > In file included from arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:25:
>
> #include <acpi/processor.h>
>
> is only included around ~300, AFAICS [even in Venki's patch]... and if you
> move that above to line ~25 [but please only #ifdef'ed], you need to
>
> #include <linux/acpi.h>
>
> first.
>
> Could you try that out, please?
getting closer. just some missing defs introduced by this patch now.
CC arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c: In function `centrino_cpu_init_acpi':
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:348: error: `ACPI_PDC_EST_CAPABILITY_SMP' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:348: error: (Each undeclared identifier is reported only once
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:348: error: for each function it appears in.)
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:348: error: `ACPI_PDC_EST_CAPABILITY_MSR' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o] Error 1
make: *** [arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o] Error 2
Dave
next prev parent reply other threads:[~2004-08-03 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-02 22:45 post-OLS pending cpufreq patches Pallipadi, Venkatesh
2004-08-03 12:42 ` Dominik Brodowski
2004-08-03 13:17 ` Dave Jones
2004-08-03 13:30 ` Dominik Brodowski
2004-08-03 13:37 ` Dave Jones [this message]
2004-08-03 14:07 ` Dominik Brodowski
2004-08-03 14:19 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2004-08-03 15:06 Pallipadi, Venkatesh
2004-07-27 20:51 Dominik Brodowski
2004-07-28 13:59 ` Dave Jones
2004-07-28 17:25 ` Dominik Brodowski
2004-08-02 19:33 ` Dave Jones
2004-08-02 20:40 ` Dominik Brodowski
2004-08-02 20:42 ` Dominik Brodowski
2004-08-02 20:52 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040803133724.GM12724@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@www.linux.org.uk \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.