All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <iod00d@hp.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Grant Grundler <iod00d@hp.com>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	linux-ia64@vger.kernel.org, Jesse Barnes <jbarnes@engr.sgi.com>,
	linux-kernel@vger.kernel.org, fastboot@osdl.org
Subject: Re: [Fastboot] Re: [BROKEN PATCH] kexec for ia64
Date: Thu, 05 Aug 2004 15:39:29 +0000	[thread overview]
Message-ID: <20040805153929.GC6526@cup.hp.com> (raw)
In-Reply-To: <m1hdri2uw0.fsf@ebiederm.dsl.xmission.com>

On Wed, Aug 04, 2004 at 08:14:55PM -0600, Eric W. Biederman wrote:
> VGA/serial console devices rarely need to do be bus masters so they
> should be fine.

yeah - you are right. I wasn't thinking.
Can anyone comment on UGA or other console devices?

> In the general case it appears to be overkill, incorrect and
> insufficient to disable bus mastering on all PCI devices.  Which is
> why device_shutdown() calls device specific code.

Is anyone else considering using kexec() to recover from a oops/panic?
What is the risk calling multiple device_shutdown() will expose another panic?

While calling a device specific cleanup is best, I worry about how
much code/data gets touched in this path. I was hoping something
simple like twiddling bus master bit would be sufficient.
If it's not, oh well.

thanks,
grant

WARNING: multiple messages have this Message-ID (diff)
From: Grant Grundler <iod00d@hp.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Grant Grundler <iod00d@hp.com>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	linux-ia64@vger.kernel.org, Jesse Barnes <jbarnes@engr.sgi.com>,
	linux-kernel@vger.kernel.org, fastboot@osdl.org
Subject: Re: [Fastboot] Re: [BROKEN PATCH] kexec for ia64
Date: Thu, 5 Aug 2004 08:39:29 -0700	[thread overview]
Message-ID: <20040805153929.GC6526@cup.hp.com> (raw)
In-Reply-To: <m1hdri2uw0.fsf@ebiederm.dsl.xmission.com>

On Wed, Aug 04, 2004 at 08:14:55PM -0600, Eric W. Biederman wrote:
> VGA/serial console devices rarely need to do be bus masters so they
> should be fine.

yeah - you are right. I wasn't thinking.
Can anyone comment on UGA or other console devices?

> In the general case it appears to be overkill, incorrect and
> insufficient to disable bus mastering on all PCI devices.  Which is
> why device_shutdown() calls device specific code.

Is anyone else considering using kexec() to recover from a oops/panic?
What is the risk calling multiple device_shutdown() will expose another panic?

While calling a device specific cleanup is best, I worry about how
much code/data gets touched in this path. I was hoping something
simple like twiddling bus master bit would be sufficient.
If it's not, oh well.

thanks,
grant

  reply	other threads:[~2004-08-05 15:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 22:24 [BROKEN PATCH] kexec for ia64 Jesse Barnes
2004-07-26 22:36 ` Jesse Barnes
2004-07-26 23:09 ` David Mosberger
2004-07-26 23:30 ` David Mosberger
2004-07-26 23:34 ` Jesse Barnes
2004-07-26 23:42 ` David Mosberger
2004-07-27  8:24 ` Christian Hildner
2004-07-27 14:49 ` Jesse Barnes
2004-07-27 16:50 ` Luck, Tony
2004-07-30 22:55 ` Randy.Dunlap
2004-08-04 13:07   ` Eric W. Biederman
2004-08-04 13:07     ` Eric W. Biederman
2004-08-04 16:24     ` Jesse Barnes
2004-08-04 16:24       ` Jesse Barnes
2004-08-04 23:33     ` Grant Grundler
2004-08-04 23:33       ` Grant Grundler
2004-08-05  2:14       ` [Fastboot] " Eric W. Biederman
2004-08-05  2:14         ` Eric W. Biederman
2004-08-05 15:39         ` Grant Grundler [this message]
2004-08-05 15:39           ` Grant Grundler
2004-08-05 16:44           ` Eric W. Biederman
2004-08-05 16:44             ` Eric W. Biederman
2004-08-05 19:44         ` Tolentino, Matthew E
2004-08-05 19:44           ` Tolentino, Matthew E
2004-08-05 21:29           ` Eric W. Biederman
2004-08-05 21:29             ` Eric W. Biederman
2004-08-05 22:15         ` Eric W. Biederman
2004-08-05 16:45 ` Luck, Tony
2004-08-05 16:45   ` Luck, Tony
2004-08-05 17:05   ` [Fastboot] " Eric W. Biederman
2004-08-05 17:05     ` Eric W. Biederman
2004-08-05 19:18     ` Khalid Aziz
2004-08-05 19:18       ` Khalid Aziz
2004-08-05 18:28 ` Grant Grundler
2004-08-05 18:56 ` Eric W. Biederman
2004-08-05 21:24 ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040805153929.GC6526@cup.hp.com \
    --to=iod00d@hp.com \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@osdl.org \
    --cc=jbarnes@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.