Re: [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14 c

[Tom Rini <trini@kernel.crashing.org>]

On Thu, Aug 05, 2004 at 07:39:26PM +0200, Olaf Hering wrote:
>  On Thu, Aug 05, Tom Rini wrote:
> 
> > On Thu, Aug 05, 2004 at 07:00:44PM +0200, Olaf Hering wrote:
> > >  On Thu, Aug 05, Tom Rini wrote:
> > > 
> > > > On Thu, Aug 05, 2004 at 04:12:57PM +0200, Olaf Hering wrote:
> > > > >  On Fri, Jul 30, Tom Rini wrote:
> > > > > 
> > > > > > 
> > > > > > +aflags-$(CONFIG_PPC64BRIDGE)	+= -mppc64bridge
> > > > > 
> > > > > this should be -Wa,-mppc64bridge for some reasons.
> > > > 
> > > > That, er, doesn't make sense.  The assembler needs -Wa,?
> > > 
> > > The cmdline was 'gcc .. -mppc64bridge ..'
> > > But there is more breakage with g5 32bit, I'm looking at it right now.
> > 
> > Hmm.  Was cflags-... done correctly?
> 
> I have currently no idea whats going on with the cflags. power3 and g5
> fails for me with current binutils and hammer branch.
> 
> g5 needs the altivec option, because -maltivec -mppc64bridge  will disable
> altivec again in as. And arch/ppc/kernel/Makefile adds -mppc64bridge
> after the cflags in arch/ppc/Makefile. Maybe the EXTRA_CFLAGS can be
> removed from arch/ppc/kernel/Makefile?

EXTRA_CFLAGS can go, yes (I was assuming -rc2 then -final, or I would
have done this already_.  The problem looks like AFLAGS being used when
CFLAGS are wanted to be used.

-- 
Tom Rini
http://gate.crashing.org/~trini/