[uml-devel] Bug in hostfs

[uml-devel] Bug in hostfs

[Peter Hartshorn]

I just started hacking in uml. First thing I did was to re-enable reporting of 
real uid and gid for hostfs files (I needed it). Then I noticed that I could 
only write to a file if it had the execute bit set (ie 0744). I narrowed this 
down to the following:

file: arch/um/fs/hostfs/host_fs.c
line: 60

original:
static int access_file(char *file, int uid, int gid, int r, int w, int x,

modified:
static in access_file(char *file, int r, int w, int x, int uid, int gid,

So, as you can see, the parameters for the function were in the wrong order.
The order was also changed in the hostfs.h file.

PS. sorry about the lack of a patch (I didn't think it was a big enough patch)



-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Bug in hostfs

[Jeff Dike]

On Sat, Aug 07, 2004 at 06:59:12PM +1000, Peter Hartshorn wrote:
> original:
> static int access_file(char *file, int uid, int gid, int r, int w, int x,
> 
> modified:
> static in access_file(char *file, int r, int w, int x, int uid, int gid,
> 
> So, as you can see, the parameters for the function were in the wrong order.
> The order was also changed in the hostfs.h file.

Fixed, nice spotting..

				Jeff




-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel