From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>, jgarzik@pobox.com
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: [patch] 2.6.8-rc3-mm2: sk98lin/skge.c doesn't compile with PROC_FS=n
Date: Mon, 9 Aug 2004 04:17:41 +0200 [thread overview]
Message-ID: <20040809021741.GL26174@fs.tum.de> (raw)
In-Reply-To: <20040808152936.1ce2eab8.akpm@osdl.org>
I got the following compile error with CONFIG_PROC_FS=n:
<-- snip -->
...
CC drivers/net/sk98lin/skge.o
drivers/net/sk98lin/skge.c: In function `skge_remove_one':
drivers/net/sk98lin/skge.c:5116: warning: implicit declaration of function `remove_proc_entry'
drivers/net/sk98lin/skge.c:5116: `pSkRootDir' undeclared (first use in this function)
drivers/net/sk98lin/skge.c:5116: (Each undeclared identifier is reported only once
drivers/net/sk98lin/skge.c:5116: for each function it appears in.)
drivers/net/sk98lin/skge.c: In function `skge_init':
drivers/net/sk98lin/skge.c:5188: `SK_Root_Dir_entry' undeclared (first use in this function)
make[3]: *** [drivers/net/sk98lin/skge.o] Error 1
<-- snip -->
The fix is pretty straightforward:
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.8-rc3-mm2-full/drivers/net/sk98lin/skge.c.old 2004-08-09 04:11:31.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full/drivers/net/sk98lin/skge.c 2004-08-09 04:13:58.000000000 +0200
@@ -110,10 +110,7 @@
#include <linux/module.h>
#include <linux/init.h>
-
-#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
-#endif
#include "h/skdrv1st.h"
#include "h/skdrv2nd.h"
@@ -5185,9 +5182,9 @@
{
int error;
+#ifdef CONFIG_PROC_FS
memcpy(&SK_Root_Dir_entry, BOOT_STRING, sizeof(SK_Root_Dir_entry) - 1);
-#ifdef CONFIG_PROC_FS
pSkRootDir = proc_mkdir(SK_Root_Dir_entry, proc_net);
if (!pSkRootDir) {
printk(KERN_WARNING "Unable to create /proc/net/%s",
next prev parent reply other threads:[~2004-08-09 2:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 22:29 2.6.8-rc3-mm2 Andrew Morton
2004-08-08 22:55 ` 2.6.8-rc3-mm2 Brice Goglin
2004-08-08 23:04 ` 2.6.8-rc3-mm2 Andrew Morton
2004-08-08 23:17 ` 2.6.8-rc3-mm2 Andrew Morton
2004-08-09 2:17 ` Adrian Bunk [this message]
2004-08-09 5:14 ` 2.6.8-rc3-mm2 (compile stats) John Cherry
2004-08-09 8:20 ` 2.6.8-rc3-mm2 Rick Lindsley
2004-08-09 8:25 ` 2.6.8-rc3-mm2 Andrew Morton
2004-08-09 8:29 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 8:33 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 8:43 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 8:49 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 10:36 ` 2.6.8-rc3-mm2 Espen Fjellvær Olsen
2004-08-09 12:14 ` 2.6.8-rc3-mm2 Vladimir V. Saveliev
2004-08-09 17:51 ` 2.6.8-rc3-mm2 Hans Reiser
2004-08-09 17:50 ` 2.6.8-rc3-mm2 Johannes Stezenbach
2004-08-09 18:22 ` 2.6.8-rc3-mm2 Jesse Barnes
2004-08-09 18:25 ` 2.6.8-rc3-mm2 Andrew Morton
2004-08-09 18:32 ` 2.6.8-rc3-mm2 Jesse Barnes
2004-08-09 19:17 ` 2.6.8-rc3-mm2 Jesse Barnes
2004-08-09 19:53 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 20:43 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 21:10 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-09 22:45 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 6:34 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 8:02 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 8:30 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 8:56 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 9:00 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 9:06 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 8:04 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 8:08 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 8:17 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 8:23 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 9:00 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 9:38 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 10:02 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 11:53 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 12:52 ` 2.6.8-rc3-mm2 V13
2004-08-10 12:51 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 12:55 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 12:56 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 13:01 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 13:10 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 13:12 ` 2.6.8-rc3-mm2 Russell King
2004-08-10 13:16 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 13:39 ` 2.6.8-rc3-mm2 Russell King
2004-08-10 13:48 ` 2.6.8-rc3-mm2 Ingo Molnar
2004-08-10 6:32 ` 2.6.8-rc3-mm2 William Lee Irwin III
2004-08-10 8:34 ` 2.6.8-rc3-mm2 Rick Lindsley
2004-08-10 14:55 ` 2.6.8-rc3-mm2 Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809021741.GL26174@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.