From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ia64@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
grif@cs.ucr.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] QLogic ISP2x00: remove needless busyloop
Date: Mon, 09 Aug 2004 21:16:20 +0000 [thread overview]
Message-ID: <20040809221620.B10454@infradead.org> (raw)
In-Reply-To: <200408091508.27773.bjorn.helgaas@hp.com>; from bjorn.helgaas@hp.com on Mon, Aug 09, 2004 at 03:08:27PM -0600
On Mon, Aug 09, 2004 at 03:08:27PM -0600, Bjorn Helgaas wrote:
> > > In general, I think if a driver is in the tree, it should be fair
> > > game for bugfixes. In fact, I see you did the most recent one to
> > > qlogicfc :-)
> >
> > That wasn't a bugfix, look harder.
>
> My apologies. I should have written "if a driver is in the
> tree, it should be fair game to improve it."
I don't object to the patch. But it was a _very_ _strong_ _hint_ that you
did something wrong if the patch actually matters for you.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ia64@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
grif@cs.ucr.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] QLogic ISP2x00: remove needless busyloop
Date: Mon, 9 Aug 2004 22:16:20 +0100 [thread overview]
Message-ID: <20040809221620.B10454@infradead.org> (raw)
In-Reply-To: <200408091508.27773.bjorn.helgaas@hp.com>; from bjorn.helgaas@hp.com on Mon, Aug 09, 2004 at 03:08:27PM -0600
On Mon, Aug 09, 2004 at 03:08:27PM -0600, Bjorn Helgaas wrote:
> > > In general, I think if a driver is in the tree, it should be fair
> > > game for bugfixes. In fact, I see you did the most recent one to
> > > qlogicfc :-)
> >
> > That wasn't a bugfix, look harder.
>
> My apologies. I should have written "if a driver is in the
> tree, it should be fair game to improve it."
I don't object to the patch. But it was a _very_ _strong_ _hint_ that you
did something wrong if the patch actually matters for you.
next prev parent reply other threads:[~2004-08-09 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 18:52 [PATCH] QLogic ISP2x00: remove needless busyloop Bjorn Helgaas
2004-08-09 20:03 ` Christoph Hellwig
2004-08-09 20:19 ` Bjorn Helgaas
2004-08-09 20:21 ` Christoph Hellwig
2004-08-09 20:21 ` Christoph Hellwig
2004-08-09 21:08 ` Bjorn Helgaas
2004-08-09 21:08 ` Bjorn Helgaas
2004-08-09 21:16 ` Christoph Hellwig [this message]
2004-08-09 21:16 ` Christoph Hellwig
2004-08-09 21:11 ` David S. Miller
2004-08-09 21:15 ` Christoph Hellwig
2004-08-09 21:20 ` David S. Miller
2004-08-09 21:27 ` Christoph Hellwig
2004-08-09 21:16 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809221620.B10454@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=grif@cs.ucr.edu \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.